Skip to content

Buttons and labels for complicated forms#4328

Merged
mauromsl merged 9 commits into
masterfrom
typesetting-166-assignment-files
Aug 8, 2024
Merged

Buttons and labels for complicated forms#4328
mauromsl merged 9 commits into
masterfrom
typesetting-166-assignment-files

Conversation

@joemull

@joemull joemull commented Jul 17, 2024

Copy link
Copy Markdown
Member

This adds a few template tags, widgets, and model properties that I used in fixing openlibhums/typesetting#166.

  • A set of buttons that select or deselect all the checkbox inputs in a fieldset (an upgrade of of the jquery-based check_all.js, which could only be used once per page and was not accessible)

  • A detail method on the galley object to make it possible to provide information about the linked file in a form choice
    image

  • A set of buttons that make it easier to quickly infill a date
    image

  • Support for initiating multiple datatables on a single page

@ajrbyers ajrbyers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cool utilities in here, I've added some comments to think about.

Comment thread src/core/templatetags/uuid.py Outdated
Comment thread src/core/templatetags/due_dates.py Outdated
Comment thread src/core/templatetags/due_dates.py
Comment thread src/templates/admin/core/widgets/select_all.html
Comment thread src/templates/admin/core/widgets/select_all.html Outdated
Comment thread src/templates/admin/core/widgets/soon_date_buttons.html
@ajrbyers ajrbyers assigned joemull and unassigned ajrbyers Jul 23, 2024
@joemull joemull requested a review from ajrbyers July 24, 2024 14:11
@joemull joemull assigned ajrbyers and unassigned joemull Jul 24, 2024
@ajrbyers ajrbyers requested a review from mauromsl August 7, 2024 10:52
@ajrbyers ajrbyers assigned mauromsl and unassigned ajrbyers Aug 7, 2024

@mauromsl mauromsl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this!

@mauromsl mauromsl merged commit 04b4124 into master Aug 8, 2024
@mauromsl mauromsl deleted the typesetting-166-assignment-files branch August 8, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants