A warning will show in prepublication when an article has no license set.#4219
Merged
Conversation
mauromsl
approved these changes
May 31, 2024
Member
Author
|
Note: discussed with @mauromsl and decided that adding a warning for non CC licenses was a too opinionated. |
joemull
requested changes
May 31, 2024
joemull
left a comment
joemull
left a comment
Member
There was a problem hiding this comment.
One of these doesn't have target="_blank". Is that intentional?
The projected issue one (not changed in this PR) doesn't have one either.
This commit also adds screen reader only spans to warn users that links open in new tabs.
Member
Author
Thanks Joe, I've added that in. The projected issue link opens a modal so doesn't require one. |
joemull
requested changes
Jun 4, 2024
joemull
left a comment
joemull
left a comment
Member
There was a problem hiding this comment.
"Opens in new tab" is nice, but this syntax sr-only is not used in foundation, is it?
It looks like it's included in font-awesome, but that's not what we want to draw on here, right?
joemull
approved these changes
Jun 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2270