Skip to content

#3909 table popups updated to have unique ids#4183

Merged
ajrbyers merged 1 commit into
masterfrom
3909-large-table-popup-duplicate-id-bugfix
May 16, 2024
Merged

#3909 table popups updated to have unique ids#4183
ajrbyers merged 1 commit into
masterfrom
3909-large-table-popup-duplicate-id-bugfix

Conversation

@StephDriver

Copy link
Copy Markdown
Member

Table modal originally was a copy of table, so all ids were same as original ids. Not all elements in table have id.

  • prefix copy-of-
  • added to table id
  • added to all child ids of that table

paired programming with @mauromsl

Closes #3909

@mauromsl mauromsl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mauromsl mauromsl requested a review from ajrbyers May 16, 2024 13:50
@mauromsl mauromsl assigned ajrbyers and unassigned ajrbyers May 16, 2024

@ajrbyers ajrbyers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ajrbyers ajrbyers merged commit 8e89eea into master May 16, 2024
@ajrbyers ajrbyers deleted the 3909-large-table-popup-duplicate-id-bugfix branch May 16, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

element IDs are not unique

3 participants