3936 add alt text to social media buttons#4178
Merged
Merged
Conversation
This was referenced May 13, 2024
ajrbyers
requested changes
Jun 26, 2024
ajrbyers
left a comment
ajrbyers
left a comment
Member
There was a problem hiding this comment.
This is great but as they're on the front of house we should mark the aria-labels as translatable!
ajrbyers
approved these changes
Jul 11, 2024
joemull
approved these changes
Jul 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All tested with Mac Voice Over. Related bugs noticed (such as difference in order between visual and tab) which will feed into the current A11y audit, but as for what was reported in this issue, that has now been fixed.
Closes #3936