3621 password reset email validation rebased#4177
Merged
Merged
Conversation
ajrbyers
requested changes
Jun 4, 2024
Member
There was a problem hiding this comment.
This is a very welcome change. Now that this page is using a Django form we should also display any form errors returned when the form is not valid. This can be done by adding the following include to each of the templates:
{% include "elements/forms/errors.html" with form=your_form_name_here %}
Member
Author
|
error validation added and tested. |
ajrbyers
approved these changes
Jun 26, 2024
mauromsl
requested changes
Aug 6, 2024
mauromsl
left a comment
mauromsl
left a comment
Member
There was a problem hiding this comment.
Thanks @StephDriver just a very minor nitpick (sorry!)
StephDriver
force-pushed
the
3621-password_reset_email_validation_rebased
branch
from
514cbb6 to
5dcc5b7
Compare
mauromsl
approved these changes
Aug 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
created a new GetResetToken form and linked through to each of the three themes.
Closes #3621