Updates to class-based view for filterable lists#4173
Conversation
joemull
changed the title
joemull
changed the title
mauromsl
left a comment
mauromsl
left a comment
There was a problem hiding this comment.
These look to be some useful new facets.
I've found a couple minor areas were we can improve the implementation, particularly one around polymorphism
mauromsl
left a comment
mauromsl
left a comment
There was a problem hiding this comment.
one last minor nitpick that I'll flag as optional
The if/else check deleted in this commit was used in an earlier version of the view to let the user filter by whether data was missing on a given facet. In other words, we wanted to be able to send [something]__isnull=True in the query. This was superceded with another appraoch, where some option representing missing data was added to choices in a select field, and translated into the query by means of an annotation.
joemull
force-pushed
the
cb-63-supporter-management
branch
from
6b9924f to
057ae67
Compare
|
@ajrbyers rebasing done. |
ajrbyers
left a comment
ajrbyers
left a comment
There was a problem hiding this comment.
Just one comment, it doesn't block this PR from being merged but we will need to address it before deployment:
This PR removes FilteredArticlesListView which is in use in the isolinear plugin.
Good Catch, we'll need to still support this with a deprecation warning
Good catch! @joemull can we preserve the name |
3 participants
These changes were made to provide functionality for openlibhums/consortial_billing#65.
They update the filterable class-based view in these ways: