Skip to content

[1.5.2] Fix a bug that kept some rich-text fields from saving#4091

Merged
joemull merged 2 commits into
b_1_5_2from
4088-jqte-hotfix-rebased-on-1-5-2
Apr 11, 2024
Merged

[1.5.2] Fix a bug that kept some rich-text fields from saving#4091
joemull merged 2 commits into
b_1_5_2from
4088-jqte-hotfix-rebased-on-1-5-2

Conversation

@joemull

@joemull joemull commented Apr 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes #4088.

I checked all the places we include JQTE in forms, and made sure they did not interfere with a TinyMCE-powered field. These were the only two problems:

  • src/templates/admin/review/revision/request_revisions.html
  • src/templates/admin/review/draft_decision.html

JQTE forms that do not interfere with a TinyMCE field

I checked and cleared these fields:

  • src/templates/admin/press/merge_users.html: {% include "elements/jqte.html" %}
  • src/templates/admin/copyediting/author_review.html: {% include "elements/jqte.html" %}
  • src/templates/admin/copyediting/editor_review.html: {% include "elements/jqte.html" %}
  • src/templates/admin/copyediting/edit_assignment.html: {% include "elements/jqte.html" %}
  • src/templates/admin/copyediting/do_copyedit.html:{% include "elements/jqte.html" %}
  • src/templates/admin/copyediting/add_copyeditor_assignment.html: {% include "elements/jqte.html" %}
  • src/templates/admin/submission/submit_funding.html: {% include "admin/elements/jqte.html" %}
  • src/templates/admin/review/suggest_reviewers.html:{% include "elements/jqte.html" %}
  • src/templates/admin/review/revision/request_revisions_notification.html:{% include "elements/jqte.html" %}
  • src/templates/admin/review/send_review_reminder.html: {% include "elements/jqte.html" %}
  • src/templates/admin/review/revision/edit_revision_request.html: {% include "elements/jqte.html" %}
  • src/templates/admin/repository/notification.html: {% include "elements/jqte.html" %}
  • src/templates/admin/review/revision/view_revision.html:{% include "elements/jqte.html" %}
  • src/templates/admin/review/reset.html: {% include "elements/jqte.html" %}
  • src/templates/admin/repository/review/notify_reviewer.html: {% include "admin/elements/jqte.html" %}
  • src/templates/admin/cron/create_template.html:{% include "admin/elements/jqte.html" %}
  • src/core/homepage_elements/html/templates/html_settings.html: {% include "elements/jqte.html" %}
  • src/core/homepage_elements/about/templates/about_settings.html:{% include "elements/jqte.html" %}

Out of scope

These fields are not actively used:

  • src/templates/admin/install/journal.html:{% include "elements/jqte.html" %}
  • src/core/homepage_elements/preprints/templates/preprints.html: {% include "elements/jqte.html" %}
  • src/templates/admin/production/assign_typesetter.html: {% include "elements/jqte.html" %}
  • src/templates/admin/production/typeset_task.html: {% include "elements/jqte.html" %}
  • src/templates/admin/production/assigned_article.html: {% include "elements/jqte.html" %}
  • src/templates/admin/production/edit_typesetter_assignment.html: {% include "elements/jqte.html" %}
  • src/templates/admin/production/notify_typesetter.html: {% include "elements/jqte.html" %}
  • src/templates/admin/proofing/proofing_article.html: {% include "elements/jqte.html" %}
  • src/templates/admin/proofing/notify_typesetter_changes.html: {% include "elements/jqte.html" %}
  • src/templates/admin/proofing/notify_proofreader.html: {% include "elements/jqte.html" %}
  • src/templates/admin/proofing/do_proofing.html: {% include "elements/jqte.html" %}
  • src/templates/admin/proofing/request_typesetting_changes.html: {% include "elements/jqte.html" %}
  • src/templates/admin/proofing/edit_proofing_assignment.html: {% include "elements/jqte.html" %}
  • src/templates/admin/proofing/complete_proofing.html: {% include "elements/jqte.html" %}
  • src/templates/admin/proofing/typesetting/typesetting_corrections.html: {% include "elements/jqte.html" %}
  • src/templates/admin/proofing/acknowledge.html: {% include "elements/jqte.html" %}

@joemull joemull requested a review from mauromsl April 11, 2024 14:43
@joemull joemull mentioned this pull request Apr 11, 2024
Closed
@joemull joemull marked this pull request as ready for review April 11, 2024 14:45
@joemull joemull removed the request for review from mauromsl April 11, 2024 14:45
@joemull joemull merged commit db92d3e into b_1_5_2 Apr 11, 2024
@joemull joemull deleted the 4088-jqte-hotfix-rebased-on-1-5-2 branch April 11, 2024 14:45
@joemull joemull linked an issue Apr 11, 2024 that may be closed by this pull request
Revision Request Notes Not Saving as of 1.5.1 #4088
Closed
@joemull

joemull commented Apr 11, 2024

Copy link
Copy Markdown
Member Author

This was merged without review because it was a hotfix while some of the team were on annual leave.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Revision Request Notes Not Saving as of 1.5.1

1 participant

@joemull