Skip to content

#3088 Editors can now determine whether the date submitted and date accepted display for their articles on all themes#4062

Merged
ajrbyers merged 2 commits into
masterfrom
3088-date_submitted_option
Apr 2, 2024
Merged

#3088 Editors can now determine whether the date submitted and date accepted display for their articles on all themes#4062
ajrbyers merged 2 commits into
masterfrom
3088-date_submitted_option

Conversation

@ajrbyers

@ajrbyers ajrbyers commented Mar 28, 2024

Copy link
Copy Markdown
Member
  • Closes Show Submitted Date #3088
  • Unifies the display of date_submitted and date_accepted by introducing settings and adding them to all themes.
Screenshot 2024-03-28 at 10 43 26 Screenshot 2024-03-28 at 10 42 21 Screenshot 2024-03-28 at 10 42 29

Note: OLH displays date published in the metrics/summary box.

@ajrbyers ajrbyers requested a review from mauromsl March 28, 2024 10:47

@mauromsl mauromsl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor comment on setting description

Comment thread src/utils/install/journal_defaults.json Outdated
Comment on lines +5092 to +5093
"description": "When enabled the date this article was accepted will be displayed along with the date accepted and date published on the article page.",
"is_translatable": false,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it "this article" or "all articles"

@ajrbyers ajrbyers requested a review from mauromsl April 2, 2024 09:31
@ajrbyers ajrbyers merged commit 0594c37 into master Apr 2, 2024
@ajrbyers ajrbyers deleted the 3088-date_submitted_option branch April 2, 2024 09:31
@ajrbyers ajrbyers requested a review from S-Haime April 2, 2024 10:05

@S-Haime S-Haime left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good, no comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show Submitted Date

3 participants