Flexible resizing but no fullscreen for TinyMCE editor#4035
Closed
joemull wants to merge 1 commit into
Closed
Conversation
mauromsl
reviewed
Mar 20, 2024
Member
There was a problem hiding this comment.
I had decided against using "both" for the resize as it allows the iframe to flow outside its horizontal boundary and severely overlap with potential elements rendered side-by-side e.g:
I don't think we should enable this by default.
The keyboard shortcuts for toggling full screen are ctrl+shift+f and setting Esc as a shortcut has even more unintended consequences.
Another option is to use the fullscreen_native setting, which will use the browser native API for full screen and supports the Esc key. In fact I think I prefer this approach now that I've tried it. Here is an alternative PR: #4045
Member
Author
|
We opted to do #4045. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4034