Skip to content

Flexible resizing but no fullscreen for TinyMCE editor#4035

Closed
joemull wants to merge 1 commit into
b_1_5_2from
4034-resizing-tinymce
Closed

Flexible resizing but no fullscreen for TinyMCE editor#4035
joemull wants to merge 1 commit into
b_1_5_2from
4034-resizing-tinymce

Conversation

@joemull

@joemull joemull commented Mar 18, 2024

Copy link
Copy Markdown
Member

Fixes #4034

@mauromsl mauromsl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had decided against using "both" for the resize as it allows the iframe to flow outside its horizontal boundary and severely overlap with potential elements rendered side-by-side e.g:
image I don't think we should enable this by default.

The keyboard shortcuts for toggling full screen are ctrl+shift+f and setting Esc as a shortcut has even more unintended consequences.

Another option is to use the fullscreen_native setting, which will use the browser native API for full screen and supports the Esc key. In fact I think I prefer this approach now that I've tried it. Here is an alternative PR: #4045

@joemull

joemull commented Mar 20, 2024

Copy link
Copy Markdown
Member Author

We opted to do #4045.

@joemull joemull closed this Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants