Skip to content

Enhances the reviewer role list with additional, reviewer specific detail.#4018

Merged
mauromsl merged 5 commits into
masterfrom
3039-enhance_reviewer_role_interface
Mar 19, 2024
Merged

Enhances the reviewer role list with additional, reviewer specific detail.#4018
mauromsl merged 5 commits into
masterfrom
3039-enhance_reviewer_role_interface

Conversation

@ajrbyers

Copy link
Copy Markdown
Member

Closes #3039

  • Adds additional information when viewing the list of reviewers
  • Also enhances the standard view with history and edit buttons
  • This page also now loads much faster, with queries reduced from >2000 to <500.
image

@joemull joemull left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great--I can imagine how useful it will be!

A couple small changes that might be nice:

  • Put a default value, like an empty string, in the template on the cells for interests, number of assignments, last completed reviews, and average score, so they don't show up as "None"
  • Adjust the widths of the first three columns so they don't take up so much space, or maybe so that they adjust automatically as needed?
  • Clicking on the Edit User button and then saving the user results in being sent back to a different page, the Enrolled Users list. Is that by design? Would it be possible to return users back to the same page? Or is it not worth doing since we need to rethink how these user lists relate do one another?

@ajrbyers

ajrbyers commented Mar 13, 2024

Copy link
Copy Markdown
Member Author

Adjust the widths of the first three columns so they don't take up so much space, or maybe so that they adjust automatically as needed?

I think the issue here is that the email address won’t break because it has no spaces, it makes the email column wide.

@joemull

joemull commented Mar 13, 2024

Copy link
Copy Markdown
Member

I think the issue here is that the email address won’t break because it has no spaces, it makes the email column wide.

It doesn't have to do with the width attributes here?

https://github.com/BirkbeckCTP/janeway/blob/dcb366ef3f078a1c6b809856f984994bef6dad71/src/templates/admin/core/manager/roles/role.html#L27-L29

@ajrbyers

Copy link
Copy Markdown
Member Author

I think the issue here is that the email address won’t break because it has no spaces, it makes the email column wide.

It doesn't have to do with the width attributes here?

https://github.com/BirkbeckCTP/janeway/blob/dcb366ef3f078a1c6b809856f984994bef6dad71/src/templates/admin/core/manager/roles/role.html#L27-L29

Ah yeah, for Fname and Lname this makes a difference, for email not so much.

@ajrbyers

Copy link
Copy Markdown
Member Author

I've updated this PR with changes. The edit_user view now supports a return query string parameter, empty/none values now display --.

@ajrbyers ajrbyers requested a review from joemull March 14, 2024 13:07
@mauromsl mauromsl merged commit 5d8ef3e into master Mar 19, 2024
@mauromsl mauromsl deleted the 3039-enhance_reviewer_role_interface branch March 19, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Peer Reviewer Management/Comms

3 participants