Skip to content

Adds support for displaying issues grouped by decade#3999

Merged
joemull merged 9 commits into
masterfrom
3276-group_issues_by_year
Mar 5, 2024
Merged

Adds support for displaying issues grouped by decade#3999
joemull merged 9 commits into
masterfrom
3276-group_issues_by_year

Conversation

@ajrbyers

Copy link
Copy Markdown
Member

@ajrbyers

Copy link
Copy Markdown
Member Author

@S-Haime I've added you as a reviewer as I've updated the docs.

@joemull joemull left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. I just have some requests about markup and headings.

Comment thread src/themes/OLH/templates/elements/journal/issue_list_by_decade.html Outdated
Comment thread src/themes/OLH/templates/elements/journal/issue_list_by_decade.html
Comment thread src/themes/OLH/templates/elements/journal/issue_list_by_decade.html Outdated
Comment thread src/themes/OLH/templates/elements/journal/issue_list_by_decade.html Outdated
@joemull

joemull commented Mar 4, 2024

Copy link
Copy Markdown
Member

OK this now has two approvals. @ajrbyers do I need to wait for @S-Haime to review it or go ahead and merge it?

@S-Haime S-Haime left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good!
@joemull Apologies, I thought I had already reviewed but must not have saved properly.

@joemull joemull merged commit 4198b03 into master Mar 5, 2024
@joemull joemull deleted the 3276-group_issues_by_year branch March 5, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ability to group issues by decade

4 participants