PreprintFile download_url should point to the public url#3852
Merged
Conversation
repository_download_file is manager only view whereas repository_file_download is public view. Updating the download url so that OAI and JATS metadata contain correct url for repository item.
download_url should point to the public url
Contributor
|
Can one of the admins verify this patch? |
Contributor
|
@ajrbyers Is there any chance of getting this into -- if not before -- 1.6? |
joemull
reviewed
Mar 13, 2024
joemull
left a comment
joemull
left a comment
Member
There was a problem hiding this comment.
I wonder if it's worth changing the name of the function as well to make it more obviously distinct from repository_download_file?
Member
I'ved opened up an issue to look at renaming one or both of the download views for preprint files (#4023). |
joemull
approved these changes
Mar 13, 2024
ajrbyers
approved these changes
Mar 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
repository_download_file is manager only view whereas repository_file_download is public view. Updating the download url so that correct item url in OAI and JATS metadata for repository items.