Let HTML galley prettify be optional#3609
Closed
gamboz wants to merge 1 commit into
Closed
Conversation
Defaults to "do prettify": does not change current behavior.
ajrbyers
approved these changes
Aug 18, 2023
Member
|
closed by #4044 4044 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current behavior of
remove_css_from_htmlis to "prettify" the source of HTML galleys, but this introduces spurious spaces in constructs such as the following:⇨
(with an extra space between "2014" and the following "]")
The changes proposed here add an optional argument to
remove_css_from_html(and tosave_galleythat invokes it) so that one can decide to avoid "prettification" when saving a galley.The default value of the argument ensures that the current behavior does not change.