Rework article list as class-based view#3597
Merged
Merged
Conversation
Signed-off-by: Mauro MSL <[email protected]>
mauromsl
approved these changes
Sep 15, 2023
mauromsl
left a comment
mauromsl
left a comment
Member
There was a problem hiding this comment.
Good one, happy to see old Materialize go as a bonus (especially djang-materialize)
|
|
||
| def get_order_by_choices(self): | ||
| """ | ||
| Implemented by suclass |
Member
There was a problem hiding this comment.
typo: suclass => subclass
Usage of this method elswhere suggests that the returned value should be a list of 2-item tuples. In lieu of type annotations, can we make that clear on this docstring?
Signed-off-by: Mauro MSL <[email protected]>
ajrbyers
approved these changes
Sep 15, 2023
ajrbyers
left a comment
ajrbyers
left a comment
Member
There was a problem hiding this comment.
Just two suggestions but looks good.
Signed-off-by: Mauro MSL <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues:
In addition to fixing #3199, this work moves us closer to using class-based views for article list pages.
New things include:
Visually I moved a few things for clarity, and I hid the search form's order by to avoid confusion, but I tried to keep the interaction design similar.
Searching still takes you to a separate page. In the future I'd like to merge the list and search results pages so that they form one coherent path for finding the article(s) you want.
Screenshots:
