Upgrade materialize#3594
Merged
Merged
Conversation
Member
Author
|
Note to self:
|
ajrbyers
approved these changes
Aug 18, 2023
ajrbyers
added a commit
that referenced
this pull request
Mar 13, 2024
… rather than using stages, will also reduce the number of queries.
ajrbyers
added a commit
that referenced
this pull request
Mar 19, 2024
… rather than using stages, will also reduce the number of queries.
ajrbyers
added a commit
that referenced
this pull request
May 10, 2024
… rather than using stages, will also reduce the number of queries.
mauromsl
pushed a commit
that referenced
this pull request
May 14, 2024
… rather than using stages, will also reduce the number of queries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3425
This morning we discussed potentially keeping this out of 1.5.1 in case there are problems with custom CSS that different journals have implemented using selectors from Materialize 0.100.2.
Based on the v1 upgrade guide, there are only a few classes and attributes that are likely to need attention. The following were all changed one-to-one:
Classes
dropdown-buttonwas changed todropdown-triggerbutton-collapsewas changed tosidenav-triggerside-navwas changed tosidenavData attributes
data-activateswas changed todata-targetWhen we release this upgrade, we should encourage press managers to check their custom stylesheets for any affected selectors and to change them to the new ones.