#3404 adds some enhancements to the repository submission file upload#3479
Conversation
joemull
left a comment
joemull
left a comment
There was a problem hiding this comment.
Wanted to run this to see what it looked like and got a migration dependency error.
| class Migration(migrations.Migration): | ||
|
|
||
| dependencies = [ | ||
| ('core', '0078_auto_20230222_1317'), |
There was a problem hiding this comment.
Missing a dependency migration:
django.db.migrations.exceptions.NodeNotFoundError: Migration repository.0033_file_upload_texts dependencies reference nonexistent parent node ('core', '0078_auto_20230222_1317')There was a problem hiding this comment.
Missing a dependency migration:
django.db.migrations.exceptions.NodeNotFoundError: Migration repository.0033_file_upload_texts dependencies reference nonexistent parent node ('core', '0078_auto_20230222_1317')
The dependencies for this migration are super weird. It shouldn't require this core migration or the press one. I've removed this. Here's a screenshot of what it looks like:
There was a problem hiding this comment.
Thanks. It is now saying this needs merging with others on 1.5: CommandError: Conflicting migrations detected; multiple leaf nodes in the migration graph: (0033_file_upload_texts, 0035_alter_preprintaccess_options in repository).
There was a problem hiding this comment.
Egads. Should be okay now.
joemull
left a comment
joemull
left a comment
There was a problem hiding this comment.
Looks good, just one question about some text that is still hard-coded
| <p>{{ request.repository.name }} {% trans 'requires that all author uploads be PDF files.' %}</p> | ||
| <p>{{ request.repository.name }} {{ request.repository.require_pdf_help }}</p> | ||
| {% else %} | ||
| <p>{% trans 'You can upload a file in any format though PDF is recommended.' %}</p> |
There was a problem hiding this comment.
The new flexibility for other parts of this page is great. I wish this line were removed though, since it could potentially conflict with the custom text when someone doesn't require PDFs but wants to give other instructions. Also I don't think users need to be told any file type is allowed, since the upload will be a smooth process in that case. What if we remove the line altogether?
There was a problem hiding this comment.
The new flexibility for other parts of this page is great. I wish this line were removed though, since it could potentially conflict with the custom text when someone doesn't require PDFs but wants to give other instructions. Also I don't think users need to be told any file type is allowed, since the upload will be a smooth process in that case. What if we remove the line altogether?
Agreed. Commit incoming.
…ile_upload_help to provide instruction.
3 participants
Closes #3404