Settings file to declare what settings should be merged#2294
Merged
Conversation
Instead of mandating what settting iterables should be merged from the runtime, a user writing a custom settings module can declare a set of MERGEABLE_SETTINGS
alexdutton
approved these changes
Jul 9, 2021
alexdutton
left a comment
alexdutton
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me (just the one minor comment), and solves my problem. :-D
| LOCK = threading.Lock() | ||
|
|
||
| MERGEABLE_SETTINGS = {"INSTALLED_APPS", "MIDDLEWARE_CLASSES"} | ||
| MERGEABLE_SETTINGS = {} |
Contributor
There was a problem hiding this comment.
This doesn't look to be used anymore?
Member
Author
There was a problem hiding this comment.
We try to be extra defensive when removing public constants like this in case a plugin out there might be using them, so we keep them for at least one release cycle.
Contributor
There was a problem hiding this comment.
That makes sense :-). For full backwards-compatibility then, should this be unchanged, and be the default if it's not provided in custom_settings?
Contributor
There was a problem hiding this comment.
Oh, though as {} it's now a dictionary and not a set as before :-)
3 tasks
Member
|
test this please |
Signed-off-by: Mauro MSL <[email protected]>
Signed-off-by: Mauro MSL <[email protected]>
ajrbyers
approved these changes
Mar 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of mandating what settting iterables should be merged from the
runtime, a user writing a custom settings module can declare a set of
MERGEABLE_SETTINGS
Closes #2284