Skip to content

Allow horizontal resizing but not full screen toggling of TinyMCE editor #4034

Description

@joemull

Problem

We have currently allowed the fullscreen feature on the TinyMCE editor. It has some accessibility issues when combined with our themes. The Escape key does not allow you to exit the full-screen view on Firefox on the OLH theme or the Hourglass theme. And on the Hourglass theme, the sticky nav bar covers up the visual interface for exiting full screen. As such it is a bit of a trap.

OLH theme - no escape key

image

Hourglass theme - no Escape key or button

image

Proposed solution

Rather than enabling the fullscreen toggle, use the resize options to allow both horizontal and vertical resizing.

We currently have an invalid setting for "resize":

https://github.com/BirkbeckCTP/janeway/blob/d52b7719bf2bad26a9779246cf3305f0aa753ea2/src/core/janeway_global_settings.py#L680

image

This should be True, False, or 'both'. We can use both to allow resizing in both directions, like this:

image

Alternatives

I tried debugging the Escape key event and the covered-up nav but could not do so in the time we have.

Additional context

TinyMCE docs: Controlling user editor resizing

Metadata

Metadata

Assignees

Labels

a11yIssues that relate to acessibilitybugSomething's not working

Type

No type

Fields

No fields configured for issues without a type.

Projects

Status
Done

Relationships

None yet

Development

No branches or pull requests

Issue actions