8277369: Strange behavior of JMenuBar with RIGHT_TO_LEFT orientation, arrow keys behaves opposite traversing through keyboard by prsadhuk · Pull Request #7396 · openjdk/jdk

prsadhuk · 2022-02-09T05:39:52Z

After applying setComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) to the JMenuBar the arrow keys started to behave the opposite of what expected. Right arrow goes left and Left arrow goes right when trying to traverse through keyboard.

Fixed to reverse the direction traversal for RTL orientation.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8277369: Strange behavior of JMenuBar with RIGHT_TO_LEFT orientation, arrow keys behaves opposite traversing through keyboard

Reviewers

Phil Race (@prrace - Reviewer)
Naoto Sato (@naotoj - Reviewer)
Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7396/head:pull/7396
$ git checkout pull/7396

Update a local copy of the PR:
$ git checkout pull/7396
$ git pull https://git.openjdk.java.net/jdk pull/7396/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7396

View PR using the GUI difftool:
$ git pr show -t 7396

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7396.diff

bridgekeeper · 2022-02-09T05:40:50Z

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-02-09T05:42:27Z

@prsadhuk The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-02-09T05:51:27Z

Webrevs

mrserb · 2022-02-10T23:00:50Z

test/jdk/javax/swing/JMenuBar/MenuBarRTLBug.java

+
+    static volatile boolean passed = false;
+
+    public static void main(String[] args) throws  Exception {


The submitter said that he use the native L&F should not we check it in the test?

Might as well. Added L&F iteration in the test.

prrace

Seems to me right should move right and left move left, so OK by me but
I'd like to make sure this is seen by @naotoj too.

openjdk · 2022-02-14T20:57:45Z

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277369: Strange behavior of JMenuBar with RIGHT_TO_LEFT orientation, arrow keys behaves opposite traversing through keyboard

Reviewed-by: prr, naoto, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 121 new commits pushed to the master branch:

16f649b: 8281678: appcds/dynamicArchive/ArchiveConsistency.java fails after JDK-8279997
88fc3bf: 8280473: CI: Support unresolved JVM_CONSTANT_Dynamic constant pool entries
f07b816: 8280940: gtest os.release_multi_mappings_vm is racy
9d0a4c3: 8274238: Inconsistent type for young_list_target_length()
2604a88: 8281585: Remove unused imports under test/lib and jtreg/gc
534e557: 8256368: Avoid repeated upcalls into Java to re-resolve MH/VH linkers/invokers
95f198b: 8274980: Improve adhoc build version strings
c61d629: 8281553: Ensure we only require liveness from mach-nodes with barriers
2597206: 8280783: Parallel: Refactor PSCardTable::scavenge_contents_parallel
2632d40: 8281637: Remove unused VerifyOption_G1UseNextMarking
... and 111 more: https://git.openjdk.java.net/jdk/compare/4ea6037ea57ce7bbad00ef172dfc3c122b2317fc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

naotoj · 2022-02-14T21:07:13Z

Caret should move visually, so VK_RIGHT should move it to the right. Fine by me.

prrace · 2022-02-15T00:50:16Z

BTW I was just looking around and if you do a google search on "rtl arrow key backward" it looks to me as if multiple unrelated open source projects happen to have had the same issue (not SFAICT Java based) and came to the same conclusion.

prsadhuk · 2022-02-24T09:51:14Z

/integrate

openjdk · 2022-02-24T09:52:31Z

Going to push as commit 379fd85.
Since your change was applied there have been 233 commits pushed to the master branch:

cd3e59e: 8282299: Remove unused PartialArrayScanTask default constructor
a661003: 8281614: serviceability/sa/ClhsdbFindPC.java fails with java.lang.RuntimeException: 'In code in NMethod for jdk/test/lib/apps/LingeredApp.steadyState' missing from stdout/stderr
43dc9ef: 8281988: Create a regression test for JDK-4618767
253cf78: 8282076: Merge some debug agent changes from the loom repo
f86f38a: 8280901: MethodHandle::linkToNative stub is missing w/ -Xint
e540e0a: 8282296: (se) Pipe.open() creates a Pipe implementation that uses Unix domain sockets (win)
7dc7184: 8282309: Operation before upper case conversion
a020b6b: 8280409: JarFile::getInputStream can fail with NPE accessing ze.getName()
99b8ed9: 8281217: Source file launch with security manager enabled fails
35076af: 8281376: Consider polymorphic methods when looking for overrides
... and 223 more: https://git.openjdk.java.net/jdk/compare/4ea6037ea57ce7bbad00ef172dfc3c122b2317fc...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-02-24T09:52:45Z

@prsadhuk Pushed as commit 379fd85.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

RTL Fix

ac8ddd1

openjdk bot added the client [email protected] label Feb 9, 2022

prsadhuk added 2 commits February 9, 2022 05:44

RTL Fix

9bbd666

RTL Fix

8afcf22

openjdk bot added the rfr Pull request is ready for review label Feb 9, 2022

mrserb reviewed Feb 10, 2022

View reviewed changes

Added L&F iteration

19b72d4

openjdk bot removed the rfr Pull request is ready for review label Feb 11, 2022

fix

5ffb721

openjdk bot added the rfr Pull request is ready for review label Feb 14, 2022

prrace approved these changes Feb 14, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Feb 14, 2022

naotoj approved these changes Feb 14, 2022

View reviewed changes

mrserb approved these changes Feb 14, 2022

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Feb 24, 2022

openjdk bot closed this Feb 24, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 24, 2022

prsadhuk deleted the JDK-8277369 branch February 24, 2022 09:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8277369: Strange behavior of JMenuBar with RIGHT_TO_LEFT orientation, arrow keys behaves opposite traversing through keyboard#7396

8277369: Strange behavior of JMenuBar with RIGHT_TO_LEFT orientation, arrow keys behaves opposite traversing through keyboard#7396
prsadhuk wants to merge 5 commits intoopenjdk:masterfrom
prsadhuk:JDK-8277369

prsadhuk commented Feb 9, 2022 •

edited by openjdk bot

Loading

Uh oh!

bridgekeeper bot commented Feb 9, 2022

Uh oh!

openjdk bot commented Feb 9, 2022

Uh oh!

mlbridge bot commented Feb 9, 2022 •

edited

Loading

Uh oh!

mrserb Feb 10, 2022

Uh oh!

prsadhuk Feb 11, 2022

Uh oh!

prrace left a comment

Uh oh!

openjdk bot commented Feb 14, 2022 •

edited

Loading

Uh oh!

naotoj commented Feb 14, 2022

Uh oh!

prrace commented Feb 15, 2022

Uh oh!

prsadhuk commented Feb 24, 2022

Uh oh!

openjdk bot commented Feb 24, 2022

Uh oh!

openjdk bot commented Feb 24, 2022

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants


		static volatile boolean passed = false;

		public static void main(String[] args) throws Exception {

Conversation

prsadhuk commented Feb 9, 2022 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Feb 9, 2022

Uh oh!

openjdk bot commented Feb 9, 2022

Uh oh!

mlbridge bot commented Feb 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

mrserb Feb 10, 2022

Choose a reason for hiding this comment

Uh oh!

prsadhuk Feb 11, 2022

Choose a reason for hiding this comment

Uh oh!

prrace left a comment

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Feb 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

naotoj commented Feb 14, 2022

Uh oh!

prrace commented Feb 15, 2022

Uh oh!

prsadhuk commented Feb 24, 2022

Uh oh!

openjdk bot commented Feb 24, 2022

Uh oh!

openjdk bot commented Feb 24, 2022

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

prsadhuk commented Feb 9, 2022 •

edited by openjdk bot

Loading

mlbridge bot commented Feb 9, 2022 •

edited

Loading

openjdk bot commented Feb 14, 2022 •

edited

Loading