Skip to content

8342818: Implement JEP 509: JFR CPU-Time Profiling#25302

Closed
parttimenerd wants to merge 146 commits into
openjdk:masterfrom
parttimenerd:parttimenerd_cooperative_cpu_time_sampler
Closed

8342818: Implement JEP 509: JFR CPU-Time Profiling#25302
parttimenerd wants to merge 146 commits into
openjdk:masterfrom
parttimenerd:parttimenerd_cooperative_cpu_time_sampler

Conversation

@parttimenerd

@parttimenerd parttimenerd commented May 19, 2025 •
edited by openjdk Bot
Loading

Copy link
Copy Markdown
Contributor

This is the code for the JEP 509: CPU Time based profiling for JFR.

Currently tested using this test suite. This runs profiles the Renaissance benchmark with

  • ... different heap sizes
  • ... different GCs
  • ... different samplers (the standard JFR and the new CPU Time Sampler and both)
  • ... different JFR recording durations
  • ... different chunk-sizes

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8342818: Implement JEP 509: JFR CPU-Time Profiling (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25302/head:pull/25302
$ git checkout pull/25302

Update a local copy of the PR:
$ git checkout pull/25302
$ git pull https://git.openjdk.org/jdk.git pull/25302/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25302

View PR using the GUI difftool:
$ git pr show -t 25302

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25302.diff

Using Webrev

Link to Webrev Comment

mgronlun and others added 28 commits March 28, 2025 16:25
@mgronlun
8352251
cb6e5aa
@mgronlun
refactoring
7998b7c
@mgronlun
adjustments
33c36e8
@mgronlun
align params
1015a8c
@mgronlun
Merge branch 'master' into 8352251
74dfc37
@mgronlun
Merge branch 'master' into 8352251
27c2292
@mgronlun
Merge branch '8352251' of github.com:mgronlun/jdk into 8352251
e48905f
@mgronlun
review comments
0da2c2d
@mgronlun
Update profile.jfc
15ecfb8
@mgronlun
Update default.jfc
d6854a8
@mgronlun
Refine SamplingLatency event description
447ce85
@mgronlun
Merge branch 'master' into 8352251
5f2351c
@mgronlun
zero
283862c
@mgronlun
No invariants for sender_for_interpreter_frame
92bbfba
@mgronlun
Attempt to build Windows-AARCH64
771a397
@mgronlun
push back pd constants into pd code
ed57ed9
@mgronlun
include guards
c65bc8b
@mgronlun
Configuration and test for jdk.SafepointLatency event
b0f9c5e
@mgronlun
Merge branch 'master' into 8352251
e448090
@bulasevich @mgronlun
8350338: the minimal arm32 support
42288d3
@mgronlun
Merge branch 'master' into 8352251
0a78858
@mgronlun
adjust description
deac50b
@mgronlun
tiny adjustments
e00ebe4
@mgronlun
Merge branch 'master' into 8352251
6879e12
@mgronlun
Delay loading of Method* until safepoint
f14e1c2
@mgronlun
validate_bcp
eb8a404
@mgronlun
growable array constructur without default initialization
fdefd35
@mgronlun
additional checks
71c284a
@parttimenerd parttimenerd changed the title Parttimenerd cooperative cpu time sampler 8337789: JEP 509: JFR CPU-Time Profiling (Experimental) May 19, 2025
@parttimenerd parttimenerd mentioned this pull request May 19, 2025
Closed
3 tasks
mgronlun
mgronlun reviewed Jun 4, 2025
View reviewed changes
Comment thread src/hotspot/share/jfr/periodic/sampling/jfrThreadSampling.cpp Outdated
apangin
apangin reviewed Jun 4, 2025
View reviewed changes
Comment thread src/hotspot/os/posix/signals_posix.cpp Outdated
Comment thread src/hotspot/share/jfr/periodic/sampling/jfrSampleRequest.cpp Outdated
Comment thread src/hotspot/share/jfr/periodic/sampling/jfrCPUTimeThreadSampler.cpp Outdated
mgronlun
mgronlun reviewed Jun 4, 2025
View reviewed changes
Comment thread src/hotspot/share/jfr/periodic/sampling/jfrCPUTimeThreadSampler.cpp
mgronlun
mgronlun reviewed Jun 4, 2025
View reviewed changes
Comment thread src/hotspot/share/jfr/periodic/sampling/jfrCPUTimeThreadSampler.cpp Outdated
@openjdk openjdk Bot added the ready Pull request is ready to be integrated label Jun 4, 2025
@mgronlun

mgronlun commented Jun 4, 2025

Copy link
Copy Markdown

I am waiting for the basic CI pre-tests to come back green before I approve for integration.

No sweat, the cutoff is in CST :) and branching usually happens later in the day.

@parttimenerd

parttimenerd commented Jun 4, 2025

Copy link
Copy Markdown
Contributor Author

I know, but I want to get over it today(ish).

mgronlun
mgronlun approved these changes Jun 4, 2025
View reviewed changes

@mgronlun mgronlun left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@mgronlun

mgronlun commented Jun 4, 2025

Copy link
Copy Markdown

I know, but I want to get over it today(ish).

Go for it.

@parttimenerd

parttimenerd commented Jun 4, 2025

Copy link
Copy Markdown
Contributor Author

So I'm just waiting for Skara?

@mgronlun

mgronlun commented Jun 4, 2025

Copy link
Copy Markdown

So I'm just waiting for Skara?

You can issue the integrate command.

@parttimenerd

parttimenerd commented Jun 4, 2025

Copy link
Copy Markdown
Contributor Author

/integrate

@openjdk

openjdk Bot commented Jun 4, 2025

Copy link
Copy Markdown

Going to push as commit 5b27e9c.
Since your change was applied there have been 18 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk Bot added the integrated Pull request has been integrated label Jun 4, 2025
@openjdk openjdk Bot closed this Jun 4, 2025
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 4, 2025
@openjdk

openjdk Bot commented Jun 4, 2025

Copy link
Copy Markdown

@parttimenerd Pushed as commit 5b27e9c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mgronlun

mgronlun commented Jun 4, 2025

Copy link
Copy Markdown

Well done - now take some well-deserved rest. I'll monitor the first stages of integration.

@parttimenerd

parttimenerd commented Jun 4, 2025

Copy link
Copy Markdown
Contributor Author

Thanks, good night.

@mgronlun

mgronlun commented Jun 4, 2025

Copy link
Copy Markdown

Hope you have not got to sleep yet:

jdk/jfr/jcmd/TestJcmdStartStopDefault.java fails on Linux.

dholmes-ora
dholmes-ora reviewed Jun 5, 2025
View reviewed changes
Comment thread src/hotspot/share/jfr/periodic/sampling/jfrCPUTimeThreadSampler.cpp
@parttimenerd

parttimenerd commented Jun 5, 2025

Copy link
Copy Markdown
Contributor Author

I'm on it, darn.

@parttimenerd parttimenerd mentioned this pull request Jun 5, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

9 more reviewers
@roberttoyonaga roberttoyonaga roberttoyonaga left review comments
@egahlin egahlin egahlin left review comments
@dholmes-ora dholmes-ora dholmes-ora left review comments
@tabata-d tabata-d tabata-d left review comments
@apangin apangin apangin approved these changes
@shipilev shipilev shipilev approved these changes
@pchilano pchilano pchilano approved these changes
@TheRealMDoerr TheRealMDoerr TheRealMDoerr approved these changes
@mgronlun mgronlun mgronlun approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

hotspot [email protected] hotspot-jfr [email protected] integrated Pull request has been integrated serviceability [email protected]

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.