Merged
Conversation
maciejpirog
requested review from
corneliuhoffman,
dimitris-m and
willem-delbare
as code owners
maciejpirog
changed the title
dimitris-m
approved these changes
Mar 11, 2026
Collaborator
dimitris-m
left a comment
dimitris-m
left a comment
There was a problem hiding this comment.
Checked that the fix works:
-
The original #560 bug (non-UTF-8 source bytes crashing the RPC decode path) -- fixed by
errors="replace"on subprocess and decode calls inrpc.pyandgit.py. -
An additional issue I tested: in containers without a UTF-8 locale (e.g.
node:20-slimwithLANG=C), Python defaults stdout to ASCII encoding, and the box-drawing characters in scan output (┆) causeUnicodeEncodeError. Thesys.stdout.reconfigure(encoding="utf-8", errors="replace")inwrapper.pyfixes this. Tested baseline v1.16.3 (crashes) vs this PR (works) in that environment.
Note: --experimental is unaffected in both cases since OCaml handles its own encoding.
Merged
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Mar 13, 2026
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [opengrep/opengrep](https://github.com/opengrep/opengrep) | patch | `v1.16.3` → `v1.16.4` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>opengrep/opengrep (opengrep/opengrep)</summary> ### [`v1.16.4`](https://github.com/opengrep/opengrep/releases/tag/v1.16.4): Opengrep 1.16.4 [Compare Source](opengrep/opengrep@v1.16.3...v1.16.4) #### Improvements - Improvements in the install script by [@​dimitris-m](https://github.com/dimitris-m) in [#​610](opengrep/opengrep#610) - Fix text encoding in python CLI to prevent a bug when reading a non-utf8 character by [@​maciejpirog](https://github.com/maciejpirog) in [#​611](opengrep/opengrep#611) **Full Changelog**: <opengrep/opengrep@v1.16.3...v1.16.4> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My42NC4zIiwidXBkYXRlZEluVmVyIjoiNDMuNjQuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90IiwiYXV0b21hdGlvbjpib3QtYXV0aG9yZWQiLCJkZXBlbmRlbmN5LXR5cGU6OnBhdGNoIl19-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When encountering an incorrect UTF-8 character, an exception was raised, now we use the "replace" policy everywhere, which skips incorrect characters.
Closes #560
See the comment section in the issue for the reproduction pack (tested on macos arm + debian in docker) that can be also used to test the fix