Repository navigation
fix(studio): show a toast when saving index page conversion fails - #3404
Merged
adriangohjw merged 3 commits intoOct 5, 2026
Merged
Conversation
|
@soroush5 is attempting to deploy a commit to the Isomer Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
One or more issues must be addressed before approval.
Pull request overview
Adds user-visible error feedback when index-page conversion saves fail.
Changes:
- Displays an error toast from the save mutation’s
onErrorhandler. - Adds browser coverage for failed conversion saves.
File summaries
| File | Description |
|---|---|
| apps/studio/src/features/editing-experience/components/Drawer/RootStateDrawer.tsx | Updated as part of this pull request. |
| apps/studio/src/features/editing-experience/components/Drawer/tests/RootStateDrawer.browser.test.tsx | Updated as part of this pull request. |
Review details
Suppressed comments (1)
apps/studio/src/features/editing-experience/components/Drawer/tests/RootStateDrawer.browser.test.tsx:136
- This test never exercises the index-page conversion flow:
renderDrawerhard-codesResourceType.Page, andCONTENT_PAGEhas thecontentlayout, so the conversion infobox/modal andhandleSaveConversionToIndexPageare never reached. It directly invokes the mutation option instead, so a regression in wiring the actual conversion save could still pass. Use anIndexPagecustom-layout fixture and drive the preview/accept path (or otherwise invoke the conversion save) while simulating the mutation failure.
renderDrawer({
pageState: CONTENT_PAGE,
permalink: "about-us",
title: "About us",
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
|
Warning Endor Labs detected 1 policy violations associated with this pull request. Please review the findings that caused the policy violations.
|
adriangohjw
approved these changes
Oct 5, 2026
Contributor
Author
|
Thanks for tightening the test and merging this. |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📊 PR diff breakdown
Hey! Found that if converting the index page fails (bad network, server
error), the drawer just closes silently — the user thinks the save went
through but nothing was saved. Silent data-loss-shaped UX.
What I changed
RootStateDrawer.tsx— wired the existingonErrorpath of thesave mutation to the app's toast, so failures surface immediately
How I verified
Added a browser test that mocks a failed save and asserts the error
toast appears — red before (no toast), green after. Full studio suite
still green (3/3 browser tests pass).
Relates to #3405