Skip to content

feat: store can point to a fga.mod file#204

Merged
d-jeffery merged 1 commit into
feat/165-support-modular-modelsfrom
feat/172-store-fga-yaml
Mar 28, 2024
Merged

feat: store can point to a fga.mod file#204
d-jeffery merged 1 commit into
feat/165-support-modular-modelsfrom
feat/172-store-fga-yaml

Conversation

@d-jeffery

@d-jeffery d-jeffery commented Mar 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

  • store.fga.yaml support for modular models
  • Replace multitude of error instanceof checks with an abstract

This PR's success relies on openfga/language@18b0254

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@d-jeffery
d-jeffery force-pushed the feat/172-store-fga-yaml branch from cb9beee to 5ab5711 Compare March 27, 2024 22:22
@d-jeffery
d-jeffery marked this pull request as ready for review March 27, 2024 22:28
@d-jeffery
d-jeffery requested a review from a team as a code owner March 27, 2024 22:28
@d-jeffery
d-jeffery requested review from ewanharris and rhamzeh March 27, 2024 22:28
@d-jeffery
d-jeffery force-pushed the feat/172-store-fga-yaml branch 2 times, most recently from 3e084ee to 024b8a6 Compare March 28, 2024 00:42
rhamzeh
rhamzeh reviewed Mar 28, 2024
View reviewed changes
Comment thread server/src/dsl-utils.ts Outdated
@d-jeffery
d-jeffery force-pushed the feat/172-store-fga-yaml branch from 024b8a6 to 0176828 Compare March 28, 2024 00:54
@d-jeffery
d-jeffery requested a review from rhamzeh March 28, 2024 00:56
@d-jeffery
d-jeffery added this pull request to the merge queue Mar 28, 2024
Merged via the queue into feat/165-support-modular-models with commit a4f29b4 Mar 28, 2024
@d-jeffery
d-jeffery deleted the feat/172-store-fga-yaml branch March 28, 2024 14:59
d-jeffery added a commit that referenced this pull request Mar 28, 2024
@d-jeffery
feat: store can point to a fga.mod file (#204)
b56993f
@rhamzeh rhamzeh mentioned this pull request May 1, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes
@ewanharris ewanharris ewanharris approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@d-jeffery @rhamzeh @ewanharris