Skip to content

fix(telemetry): fixes for telemetry attributes and metrics tracking #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
evansims wants to merge 1 commit into from
Closed

fix(telemetry): fixes for telemetry attributes and metrics tracking #176

evansims wants to merge 1 commit into from

Conversation

@evansims
Copy link
Contributor

@evansims evansims commented Mar 25, 2025

Description

  • Improved client request duration handling.
  • Fixed attribute filtering issue in some configurations.
  • Updated ClientConfiguration to include telemetry configuration (like Configuration.)
  • Enhanced tests to validate new telemetry attributes and ensure correct duration calculations.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@evansims evansims added the bug Something isn't working label Mar 25, 2025
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 25, 2025 •
edited
Loading

CLA Missing ID CLA Not Signed

@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.42%. Comparing base (cefa972) to head (e9142ba).

❌ Your project status has failed because the head coverage (70.42%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
+ Coverage   70.37%   70.42%   +0.05%     
==========================================
  Files         134      134              
  Lines       10792    10798       +6     
==========================================
+ Hits         7595     7605      +10     
+ Misses       3197     3193       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@evansims evansims closed this Mar 25, 2025
@evansims evansims reopened this Mar 25, 2025
@evansims
fix(telemetry): fixes for telemetry attributes and metrics tracking
e9142ba 
- Improved client request duration handling.
- Fixed attribute filtering issue in some configurations.
- Updated `ClientConfiguration` to include telemetry configuration (like `Configuration`.)
- Enhanced tests to validate new telemetry attributes and ensure correct duration calculations.
@evansims evansims force-pushed the fix/telemetry-attributes-and-metrics-tracking branch from e97092c to e9142ba Compare March 25, 2025 06:09
@evansims evansims closed this Mar 25, 2025
@evansims evansims deleted the fix/telemetry-attributes-and-metrics-tracking branch March 25, 2025 06:31
@rhamzeh rhamzeh mentioned this pull request Apr 30, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@evansims @codecov-commenter