chore(deps:js): bump deps by rhamzeh · Pull Request #536 · openfga/language

rhamzeh · 2026-02-11T15:26:47Z

Description

What problem is being solved?

How is it being solved?

What changes are made to solve it?

References

Review Checklist

I have clicked on "allow edits by maintainers".
I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
The correct base branch is being used, if not main
I have added tests to validate that the change in functionality is working as expected

Summary by CodeRabbit

Breaking Changes
- Dropped support for Node.js 16 & 18; minimum supported version is now 20.19.0
Documentation
- Added supported Node.js versions documentation with support policy
Chores
- Updated development dependencies and added Node.js 25 to CI test matrix

coderabbitai · 2026-02-11T15:26:57Z

Caution

Review failed

Failed to post review comments

Walkthrough

Updates CI/CD workflows to support Node.js 25.x, modernizes ESLint from legacy (.eslintrc.js) to flat config (eslint.config.mjs), updates tooling dependencies and removes eslintignore patterns, adds Node.js version support documentation, and sets minimum engine requirement to 20.19.0.

Changes

Cohort / File(s)	Summary
CI/CD Workflow Updates `.github/workflows/pkg-js-build.yaml`, `.github/workflows/pkg-js-release.yaml`	Added Node.js 25.x to test matrix, removed always-auth setting, introduced TARGET_NODE_VERSION environment variable, npm cache configuration, and new tag validation step that validates semantic version format and derives npm distribution tag (alpha/beta/rc/latest) for release publishing.
ESLint Configuration Migration `pkg/js/.eslintrc.js`, `pkg/js/eslint.config.mjs`, `pkg/js/.eslintignore`	Migrated from legacy ESLint configuration (.eslintrc.js, deleted) to flat config format (eslint.config.mjs, new), removed dist/ and gen/ ignore patterns from .eslintignore, and added TypeScript/import resolver support with comprehensive rule overrides.
Node.js Version Support Documentation `pkg/js/CHANGELOG.md`, `pkg/js/README.md`, `pkg/js/SUPPORTED_RUNTIMES.md`	Added Unreleased changelog section noting drop of Node.js v16 & v18 support, added Supported Node.js Versions README section, and introduced new SUPPORTED_RUNTIMES.md documenting version support policy and currently supported versions (20, 22, 24, 25).
Dependencies & Configuration `pkg/js/package.json`, `pkg/js/.npm-upgrade.json`	Updated lint script to run eslint at project root, bumped ESLint and TypeScript-related dependencies to newer versions, added eslint-import-resolver-typescript, added node engine requirement >=20.19.0, and updated npm-upgrade ESLint ignore rule from 9.x to 10.x.
Code Cleanup `pkg/js/transformer/dsltojson.ts`	Removed ESLint lint suppression comment preceding enterTypeDef listener.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

release(js): v0.2.0 #466: Modifies the same CI workflows (.github/workflows/pkg-js-build.yaml and pkg-js-release.yaml) to update Node.js versions and test matrices.
chore(js): make [email protected] the minimum supported version #535: Makes overlapping changes to CI workflows, package.json, and Node.js version documentation files.

Suggested reviewers

jimmyjames
SoulPancake

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'chore(deps:js): bump deps' is overly vague and does not clearly convey the scope of changes beyond generic dependency bumping; the PR includes significant structural changes like ESLint migration, Node.js version requirements, CI/release workflow updates, and documentation additions that are not captured.	Consider a more descriptive title that reflects the major changes, such as 'chore(js): migrate to flat ESLint config and update Node.js minimum to 20.19.0' or similar to better convey the actual scope.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch chore/js-bump-deps

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

dosubot · 2026-02-11T15:27:07Z

Related Documentation

Checked 8 published document(s) in 1 knowledge base(s). No updates required.

^{How did I do? Any feedback?}

socket-security · 2026-02-11T15:27:12Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	npm/eslint-import-resolver-typescript@4.4.4
	npm/eslint@8.57.1 ⏵ 9.39.2	^-2		⁺¹	⁺⁴⁷

View full report

Copilot

Pull request overview

This PR updates the pkg/js (TypeScript) package’s dependency set and migrates linting from legacy .eslintrc/.eslintignore to ESLint v9’s flat config format.

Changes:

Bump JS/TS dependencies (notably ESLint v9, @typescript-eslint/*, TypeScript, Prettier, YAML).
Replace .eslintrc.js + .eslintignore with a new eslint.config.mjs.
Simplify the lint script to run ESLint with default config discovery.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
pkg/js/transformer/dsltojson.ts	Removes an obsolete ESLint suppression comment.
pkg/js/package.json	Updates dependency versions and changes the `lint` script invocation.
pkg/js/package-lock.json	Lockfile updates reflecting the dependency bumps.
pkg/js/eslint.config.mjs	Adds ESLint v9 flat config equivalent of the previous `.eslintrc.js` rules/ignores.
pkg/js/.npm-upgrade.json	Adjusts upgrade-ignore policy for ESLint major versions.
pkg/js/.eslintrc.js	Removed (replaced by flat config).
pkg/js/.eslintignore	Removed (replaced by flat config ignores).

Files not reviewed (1)

pkg/js/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings February 11, 2026 15:26

rhamzeh requested review from a team as code owners February 11, 2026 15:26

rhamzeh marked this pull request as draft February 11, 2026 15:28

Copilot started reviewing on behalf of rhamzeh February 11, 2026 15:28 View session

rhamzeh force-pushed the chore/js-bump-deps branch from b66c136 to 7e2384d Compare February 11, 2026 15:33

Copilot AI reviewed Feb 11, 2026

View reviewed changes

Comment thread pkg/js/package.json

Base automatically changed from chore/js-drop-node-16-18 to main February 11, 2026 15:57

rhamzeh marked this pull request as ready for review February 11, 2026 16:01

rhamzeh requested review from a team as code owners February 11, 2026 16:01

rhamzeh added 2 commits February 11, 2026 11:03

chore(deps:js): bump deps (except eslint)

98d2b25

chore(deps:js): bump eslint to v9

8177794

rhamzeh force-pushed the chore/js-bump-deps branch from 7e2384d to 8177794 Compare February 11, 2026 16:03

SoulPancake approved these changes Feb 11, 2026

View reviewed changes

rhamzeh added this pull request to the merge queue Feb 11, 2026

Merged via the queue into main with commit 369b1ba Feb 11, 2026
14 checks passed

rhamzeh deleted the chore/js-bump-deps branch February 11, 2026 16:48

coderabbitai Bot mentioned this pull request Feb 11, 2026

release(js): v0.2.1 #537

Merged

4 tasks

coderabbitai Bot mentioned this pull request Feb 25, 2026

chore: Complete ESLint 10 upgrade with breaking changes openfga/js-sdk#343

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(deps:js): bump deps#536

chore(deps:js): bump deps#536
rhamzeh merged 2 commits into
mainfrom
chore/js-bump-deps

rhamzeh commented Feb 11, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Feb 11, 2026 •

edited

Loading

Review failed

Uh oh!

dosubot Bot commented Feb 11, 2026

Uh oh!

socket-security Bot commented Feb 11, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

rhamzeh commented Feb 11, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

What problem is being solved?

How is it being solved?

What changes are made to solve it?

References

Review Checklist

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Uh oh!

dosubot Bot commented Feb 11, 2026

Uh oh!

socket-security Bot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rhamzeh commented Feb 11, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Feb 11, 2026 •

edited

Loading

socket-security Bot commented Feb 11, 2026 •

edited

Loading