Skip to content

release(js): v0.2.0#466

Merged
rhamzeh merged 1 commit into
mainfrom
release/js-v0.2.0
Jul 22, 2025
Merged

release(js): v0.2.0#466
rhamzeh merged 1 commit into
mainfrom
release/js-v0.2.0

Conversation

@rhamzeh

@rhamzeh rhamzeh commented Jul 22, 2025

Copy link
Copy Markdown
Member

Description

What problem is being solved?

How is it being solved?

What changes are made to solve it?

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

Summary by CodeRabbit

  • New Features

    • Now supports the use of '/' and '.' in type and relation names during parsing.
  • Bug Fixes

    • Fixed an issue where an error is now thrown if a non-module file is passed during transformation.
  • Chores

    • Updated Node.js versions used in build and release processes for improved compatibility.
    • Upgraded various dependencies to their latest versions for enhanced stability and security.
    • Added a new release entry to the changelog.

@rhamzeh
rhamzeh requested review from a team as code owners July 22, 2025 21:09
@coderabbitai

coderabbitai Bot commented Jul 22, 2025

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The updates modify JavaScript package workflows and metadata. Node.js versions are updated in GitHub Actions build and release workflows, expanding the build matrix and bumping the default to v24. The package changelog documents new features and fixes. Several dependencies in the package.json are upgraded to newer versions.

Changes

Files/Groups Change Summary
.github/workflows/pkg-js-build.yaml, ...release.yaml Updated Node.js versions in GitHub Actions workflows; build matrix expanded, release uses v24
pkg/js/CHANGELOG.md Added release entry for v0.2.0 with new feature (parsing '/' and '.' in names) and a fix for error handling
pkg/js/package.json Upgraded runtime and dev dependencies to newer versions

Estimated code review effort

2 (~15 minutes)


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@socket-security

socket-security Bot commented Jul 22, 2025

Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert (click for details)
Warn High
npm/[email protected] has a License Policy Violation.

License: CC-BY-4.0 (npm metadata)

License: CC-BY-4.0 (package/LICENSE)

License: CC-BY-4.0 (package/package.json)

From: pkg/js/package-lock.jsonnpm/@jest/[email protected]npm/[email protected]npm/[email protected]npm/[email protected]npm/[email protected]

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🔭 Outside diff range comments (1)
pkg/js/package.json (1)

1-8: Version mismatch with changelog – will break publish

CHANGELOG.md announces v0.2.0, but package.json still advertises 0.2.0-beta.22.
npm publish will either fail (version already exists) or release under the wrong tag.

-  "version": "0.2.0-beta.22",
+  "version": "0.2.0",
🧹 Nitpick comments (3)
.github/workflows/pkg-js-release.yaml (1)

34-38: Use a semver range (24.x) instead of a hard major pin

Pinning to bare 24 resolves to the very first 24.0.0 build, so you will miss security/bug-fix patch releases (e.g. 24.0.1). Prefer the wildcard patch range to stay current.

-          node-version: 24
+          node-version: 24.x

Please also double-check that Node .js 24 is already available on the GitHub-Actions runners before merging.

.github/workflows/pkg-js-build.yaml (2)

16-22: Align with semver best-practice (24.x)

Same concern as in the release workflow: switch to a patch-wildcard so CI always pulls the latest 24.*.

-          node-version: '24'
+          node-version: '24.x'

43-46: Re-evaluate matrix: remove EOL 16.x & confirm availability of 22.x / 24.x

Node 16 reached EOL in 2024-09 and no longer receives security fixes.
Conversely, 22.x and especially 24.x may not yet be shipped on every runner image.

Consider:

node-version: [18.x, 20.x, 22.x]

This keeps coverage on the two active LTS lines plus the current-latest.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between af23342 and 7ac39a3.

⛔ Files ignored due to path filters (1)
  • pkg/js/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (4)
  • .github/workflows/pkg-js-build.yaml (2 hunks)
  • .github/workflows/pkg-js-release.yaml (1 hunks)
  • pkg/js/CHANGELOG.md (1 hunks)
  • pkg/js/package.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Analyze (go)
🔇 Additional comments (2)
pkg/js/CHANGELOG.md (1)

3-15: Changelog entry LGTM

Clear notes & issue links – thanks for keeping users informed.

pkg/js/package.json (1)

38-52: Major-version bumps: verify breaking-change surface

Several dev dependencies jump multiple major versions (jest 30, eslint-plugin-import 2.32, typescript 5.8, etc.).
Make sure:

  1. ts-jest supports Jest 30 (the compat table has historically lagged).
  2. Eslint plugins & configs are mutually compatible with eslint 8.57.
  3. Your source compiles under TypeScript 5.8 without stray @ts-expect-error suppressions.

CI is the safety net, but a quick local run can save churn.

@rhamzeh
rhamzeh force-pushed the release/js-v0.2.0 branch from 7ac39a3 to 37b4e51 Compare July 22, 2025 21:30
- bump js deps, including eslint-config-prettier due to: https://x.com/JounQin/status/1946297662069993690
- ci: use node@24 as base
- ci: run tests on node 22 and 24 in addition to 16, 18 and 20
@rhamzeh
rhamzeh force-pushed the release/js-v0.2.0 branch from 37b4e51 to 6fc0827 Compare July 22, 2025 21:35
@rhamzeh
rhamzeh added this pull request to the merge queue Jul 22, 2025
Merged via the queue into main with commit 653bf15 Jul 22, 2025
17 checks passed
@rhamzeh
rhamzeh deleted the release/js-v0.2.0 branch July 22, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants