release(js): v0.2.0#466
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe updates modify JavaScript package workflows and metadata. Node.js versions are updated in GitHub Actions build and release workflows, expanding the build matrix and bumping the default to v24. The package changelog documents new features and fixes. Several dependencies in the package.json are upgraded to newer versions. Changes
Estimated code review effort2 (~15 minutes) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
pkg/js/package.json (1)
1-8: Version mismatch with changelog – will break publish
CHANGELOG.mdannouncesv0.2.0, butpackage.jsonstill advertises0.2.0-beta.22.
npm publishwill either fail (version already exists) or release under the wrong tag.- "version": "0.2.0-beta.22", + "version": "0.2.0",
🧹 Nitpick comments (3)
.github/workflows/pkg-js-release.yaml (1)
34-38: Use a semver range (24.x) instead of a hard major pinPinning to bare
24resolves to the very first 24.0.0 build, so you will miss security/bug-fix patch releases (e.g. 24.0.1). Prefer the wildcard patch range to stay current.- node-version: 24 + node-version: 24.xPlease also double-check that Node .js 24 is already available on the GitHub-Actions runners before merging.
.github/workflows/pkg-js-build.yaml (2)
16-22: Align with semver best-practice (24.x)Same concern as in the release workflow: switch to a patch-wildcard so CI always pulls the latest 24.*.
- node-version: '24' + node-version: '24.x'
43-46: Re-evaluate matrix: remove EOL 16.x & confirm availability of 22.x / 24.xNode 16 reached EOL in 2024-09 and no longer receives security fixes.
Conversely, 22.x and especially 24.x may not yet be shipped on every runner image.Consider:
node-version: [18.x, 20.x, 22.x]This keeps coverage on the two active LTS lines plus the current-latest.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pkg/js/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (4)
.github/workflows/pkg-js-build.yaml(2 hunks).github/workflows/pkg-js-release.yaml(1 hunks)pkg/js/CHANGELOG.md(1 hunks)pkg/js/package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Analyze (go)
🔇 Additional comments (2)
pkg/js/CHANGELOG.md (1)
3-15: Changelog entry LGTMClear notes & issue links – thanks for keeping users informed.
pkg/js/package.json (1)
38-52: Major-version bumps: verify breaking-change surfaceSeveral dev dependencies jump multiple major versions (
jest30,eslint-plugin-import2.32,typescript5.8, etc.).
Make sure:
ts-jestsupports Jest 30 (the compat table has historically lagged).- Eslint plugins & configs are mutually compatible with eslint 8.57.
- Your source compiles under TypeScript 5.8 without stray
@ts-expect-errorsuppressions.CI is the safety net, but a quick local run can save churn.
7ac39a3 to
37b4e51
Compare
- bump js deps, including eslint-config-prettier due to: https://x.com/JounQin/status/1946297662069993690 - ci: use node@24 as base - ci: run tests on node 22 and 24 in addition to 16, 18 and 20
37b4e51 to
6fc0827
Compare
Description
What problem is being solved?
How is it being solved?
What changes are made to solve it?
References
Review Checklist
mainSummary by CodeRabbit
New Features
Bug Fixes
Chores