Skip to content

chore(ci): add pre-release lane on develop branch#440

Merged
SoulPancake merged 1 commit into
mainfrom
chore/develop-experimental-releases
Jun 24, 2026
Merged

chore(ci): add pre-release lane on develop branch#440
SoulPancake merged 1 commit into
mainfrom
chore/develop-experimental-releases

Conversation

@SoulPancake

@SoulPancake SoulPancake commented Jun 23, 2026

Copy link
Copy Markdown
Member

Adds .github/workflows/release-please-develop.yml: a standalone workflow_dispatch + push(develop) flow that cuts pre-release-only versions (alpha/beta/rc) via release-please, GPG-signed tags and draft pre-releases. It does NOT modify or call the shared openfga/.github release-please workflow, so the stable main flow is untouched. Publishing is handled by the existing main.yaml tag trigger. Documents the develop-upstream branch model in RELEASE.md.

Description

What problem is being solved?

How is it being solved?

What changes are made to solve it?

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

Summary by CodeRabbit

  • Documentation

    • Comprehensive guide added for experimental pre-releases from the development branch, including step-by-step procedures for cutting beta and RC versions and graduating to stable releases.
  • Chores

    • Release automation infrastructure updated to support development branch pre-releases.

@SoulPancake
SoulPancake requested a review from a team as a code owner June 23, 2026 09:52
Copilot AI review requested due to automatic review settings June 23, 2026 09:52
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

A new GitHub Actions workflow (release-please-develop) is added to manage pre-release version PRs from the develop branch by delegating to a shared reusable workflow. RELEASE.md is extended with a new section documenting the full pre-release lifecycle, including cutting betas and graduating to stable.

Changes

develop Branch Pre-release Workflow and Documentation

Layer / File(s) Summary
Pre-release workflow and RELEASE.md guidance
.github/workflows/release-please-develop.yml, RELEASE.md
Adds the release-please-develop workflow triggered by workflow_dispatch (with a required release-version alpha/beta/rc input) or push to develop when the commit message starts with release:. Delegates to openfga/.github/.github/workflows/release-please-prerelease.yml@main with developrelease-develop branch mapping and wired secrets/permissions. RELEASE.md gains an "Experimental releases from develop" section with a branch promotion diagram, beta-cutting steps, and stable graduation instructions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • openfga/js-sdk#362: The initial release-please automation and RELEASE.md setup that this PR extends with the develop-branch pre-release workflow and matching documentation.

Suggested reviewers

  • rhamzeh
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title 'chore(ci): add pre-release lane on develop branch' directly and accurately describes the main change: adding a new CI/CD workflow for pre-release management on the develop branch.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/develop-experimental-releases

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

codecov-commenter commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.74%. Comparing base (6066c68) to head (6297a01).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #440   +/-   ##
=======================================
  Coverage   85.74%   85.74%           
=======================================
  Files          25       25           
  Lines        1305     1305           
  Branches      241      265   +24     
=======================================
  Hits         1119     1119           
  Misses        108      108           
  Partials       78       78           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an opt-in, self-contained pre-release lane for the develop branch using a new GitHub Actions workflow, and documents the intended develop → main promotion model so pre-release release-please commits don’t disrupt stable releases on main.

Changes:

  • Added .github/workflows/release-please-develop.yml to cut pre-release-only versions from develop via a shared reusable workflow.
  • Documented the experimental develop release process and the “promote code, not release commits” guidance in RELEASE.md.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
RELEASE.md Documents the new develop pre-release workflow and branch promotion guidance.
.github/workflows/release-please-develop.yml Introduces a dedicated workflow to create prerelease PRs/tags from develop without altering the stable main release-please lane.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread RELEASE.md
@SoulPancake
SoulPancake force-pushed the chore/develop-experimental-releases branch 2 times, most recently from cbba995 to 0af3af3 Compare June 23, 2026 10:02

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/release-please-develop.yml:
- Line 41: The reusable workflow reference in the release-please-develop.yml
file uses `@main` which is mutable and creates a supply-chain security risk given
the sensitive permissions and secrets involved. Replace the `@main` reference in
the uses statement for the
openfga/.github/.github/workflows/release-please-prerelease.yml workflow with a
specific immutable commit SHA to ensure the workflow version cannot change
unexpectedly between runs.

In `@RELEASE.md`:
- Around line 96-100: The fenced code block containing the git branch diagram is
missing a language identifier, which triggers the MD040 markdown lint rule. Add
the language identifier `text` to the opening fence of the diagram block by
changing the opening triple backticks to include the language specifier, keeping
the rest of the diagram content unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 60b1f7e0-d22e-4541-85ff-d4f99366fdee

📥 Commits

Reviewing files that changed from the base of the PR and between 6066c68 and 90a2147.

📒 Files selected for processing (2)
  • .github/workflows/release-please-develop.yml
  • RELEASE.md

Comment thread .github/workflows/release-please-develop.yml
Comment thread RELEASE.md
@SoulPancake
SoulPancake force-pushed the chore/develop-experimental-releases branch from 0af3af3 to 1f76072 Compare June 23, 2026 10:03
Adds .github/workflows/release-please-develop.yml: a standalone workflow_dispatch + push(develop) flow that cuts pre-release-only versions (alpha/beta/rc) via release-please, GPG-signed tags and draft pre-releases. It does NOT modify or call the shared openfga/.github release-please workflow, so the stable main flow is untouched. Publishing is handled by the existing main.yaml tag trigger. Documents the develop-upstream branch model in RELEASE.md.
@SoulPancake
SoulPancake force-pushed the chore/develop-experimental-releases branch from 1f76072 to 6297a01 Compare June 23, 2026 10:05
@SoulPancake

Copy link
Copy Markdown
Member Author

Making it draft right now
Will verify some runs and then reopen

@SoulPancake
SoulPancake marked this pull request as draft June 23, 2026 11:24
@SoulPancake
SoulPancake marked this pull request as ready for review June 23, 2026 11:45
@SoulPancake SoulPancake changed the title chore(ci): add self-contained experimental pre-release lane on develop chore(ci): add pre-release lane on develop branch Jun 23, 2026
@SoulPancake
SoulPancake enabled auto-merge June 24, 2026 17:06
@SoulPancake
SoulPancake added this pull request to the merge queue Jun 24, 2026
Merged via the queue into main with commit 5fb550d Jun 24, 2026
28 of 30 checks passed
@SoulPancake
SoulPancake deleted the chore/develop-experimental-releases branch June 24, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants