Skip to content

chore(eslint): bump eslint to v10#412

Merged
rhamzeh merged 2 commits into
mainfrom
chore/bump-deps
May 8, 2026
Merged

chore(eslint): bump eslint to v10#412
rhamzeh merged 2 commits into
mainfrom
chore/bump-deps

Conversation

@rhamzeh

@rhamzeh rhamzeh commented May 7, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Description

What problem is being solved?

How is it being solved?

What changes are made to solve it?

References

closes #343

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

Summary by CodeRabbit

  • Chores
    • Upgraded ESLint development dependency from version 9.x to major version 10.x with enhanced code quality analysis and performance improvements
    • Updated npm linting scripts to automatically detect and lint files across all supported formats without explicit file extension requirements
    • Optimized Dependabot configuration by simplifying dependency pattern matching and adjusting update scheduling for improved development efficiency

Copilot AI review requested due to automatic review settings May 7, 2026 22:48
@rhamzeh
rhamzeh requested a review from a team as a code owner May 7, 2026 22:48
@coderabbitai

coderabbitai Bot commented May 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a83c167d-2193-4345-ac6e-f476f7d78435

📥 Commits

Reviewing files that changed from the base of the PR and between e352c99 and af0e503.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • .github/dependabot.yaml
  • package.json

Walkthrough

This PR completes the ESLint 10 migration by bumping the version constraint, updating lint scripts to remove TypeScript-only filtering, and simplifying Dependabot rules that previously ignored ESLint updates. Example directory dependency checks are moved to weekly frequency.

Changes

ESLint 10 Upgrade

Layer / File(s) Summary
ESLint Dependency Upgrade
package.json		 ESLint devDependency upgraded from 9.39.4 to ^10.3.0.
Lint Scripts Configuration
package.json		 npm lint and lint:fix scripts updated to invoke eslint . without --ext .ts filtering.
Dependabot Configuration
.github/dependabot.yaml		 ESLint ignore rules removed, groups.dependencies simplified to patterns: ["*"], and npm schedules for /example/* directories changed from daily to weekly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • openfga/js-sdk#341: Both PRs modify ESLint devDependency version to a v10.x range and coordinate ESLint 10 upgrade changes.
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR only updates ESLint to v10 and adjusts Dependabot scheduling, but does not implement required changes from #343: typescript-eslint upgrades, flat config migration, engine version bump, and CI workflow updates. Implement all required changes from issue #343: upgrade typescript-eslint packages, migrate to eslint.config.mjs, update engines.node, and update GitHub workflows to drop old Node.js versions.
Out of Scope Changes check ❓ Inconclusive The changes to Dependabot configuration and ESLint scheduling are tangentially related but not core requirements from #343; Dependabot updates appear to be preparatory adjustments. Clarify whether the Dependabot configuration changes are necessary for this PR or if they should be separated into a distinct issue/PR for better scope management.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: bumping ESLint to v10, which is the primary objective of the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bump-deps

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter

codecov-commenter commented May 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.48%. Comparing base (6b03882) to head (af0e503).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #412      +/-   ##
==========================================
- Coverage   85.59%   85.48%   -0.11%     
==========================================
  Files          26       26              
  Lines        1270     1309      +39     
  Branches      250      265      +15     
==========================================
+ Hits         1087     1119      +32     
- Misses        110      112       +2     
- Partials       73       78       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@socket-security

socket-security Bot commented May 7, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updatedeslint@​9.39.4 ⏵ 10.3.089 +110010096100

View full report

Copilot AI reviewed May 7, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repo’s linting toolchain by upgrading ESLint to v10 and aligning related configuration/automation to support the upgrade (issue #343).

Changes:

  • Bump eslint from 9.39.4 to ^10.3.0 and update package-lock.json accordingly.
  • Simplify lint / lint:fix scripts to use eslint . (no explicit --ext .ts).
  • Update Dependabot configuration to stop ignoring ESLint updates and adjust example package update schedules.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.

File Description
package.json Upgrades ESLint to v10 and updates lint scripts accordingly.
package-lock.json Lockfile regeneration reflecting ESLint v10 and transitive dependency updates.
.github/dependabot.yaml Removes ESLint ignore/exclusion rules and changes update schedules for example packages.
Comments suppressed due to low confidence (1)

.github/dependabot.yaml:42

  • This PR changes Dependabot update cadence for the /example/streamed-list-objects package from daily to weekly, which is unrelated to the stated purpose of bumping ESLint. If intentional, please document the rationale; otherwise consider reverting to keep the PR scoped to the ESLint upgrade.
  - package-ecosystem: npm
    directory: /example/streamed-list-objects
    schedule:
      interval: weekly

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/dependabot.yaml
Comment thread .github/dependabot.yaml
Comment thread .github/dependabot.yaml
@rhamzeh
rhamzeh enabled auto-merge May 7, 2026 22:52
@rhamzeh
rhamzeh added this pull request to the merge queue May 8, 2026
Merged via the queue into main with commit 313ae1e May 8, 2026
34 checks passed
@rhamzeh
rhamzeh deleted the chore/bump-deps branch May 8, 2026 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@curfew-marathon curfew-marathon curfew-marathon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

chore: Complete ESLint 10 upgrade with breaking changes

4 participants

@rhamzeh @codecov-commenter @curfew-marathon