Skip to content

chore(ci): fix typo specifying node version env#399

Merged
rhamzeh merged 1 commit into
mainfrom
fix/publish-node-version
May 7, 2026
Merged

chore(ci): fix typo specifying node version env#399
rhamzeh merged 1 commit into
mainfrom
fix/publish-node-version

Conversation

@rhamzeh

@rhamzeh rhamzeh commented May 7, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Description

What problem is being solved?

How is it being solved?

What changes are made to solve it?

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

Summary by CodeRabbit

  • Chores
    • Updated Node.js version configuration in the build pipeline to use the correct environment variable reference.

@rhamzeh
rhamzeh requested a review from a team as a code owner May 7, 2026 04:19
@coderabbitai

coderabbitai Bot commented May 7, 2026 •
edited
Loading

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 93f26799-7d9d-4eb2-978f-0066885c3b26

📥 Commits

Reviewing files that changed from the base of the PR and between 6b03882 and b81ebac.

📒 Files selected for processing (1)
  • .github/workflows/main.yaml

Walkthrough

The PR updates the GitHub Actions workflow configuration to use the correct environment variable name. In the publish job's "Set up node" step, the Node.js version reference is changed from env.NODE_VERSION to env.TARGET_NODE_VERSION.

Changes

Workflow Configuration Update

Layer / File(s) Summary
Workflow Variable Reference
.github/workflows/main.yaml		 The publish job's Node setup step now references env.TARGET_NODE_VERSION instead of env.NODE_VERSION for the node-version parameter.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • openfga/js-sdk#247: Standardizes Node.js version variable references across multiple workflow jobs.
  • openfga/js-sdk#319: Makes related modifications to the same publish job in the main workflow file.

Suggested reviewers

  • SoulPancake
  • ewanharris
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing a typo in the CI workflow where the node version environment variable reference was corrected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/publish-node-version

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter

codecov-commenter commented May 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.59%. Comparing base (6b03882) to head (b81ebac).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #399   +/-   ##
=======================================
  Coverage   85.59%   85.59%           
=======================================
  Files          26       26           
  Lines        1270     1270           
  Branches      250      250           
=======================================
  Hits         1087     1087           
  Misses        110      110           
  Partials       73       73

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI review requested due to automatic review settings May 7, 2026 06:45
Copilot AI reviewed May 7, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the Node.js version reference in the CI workflow so the publish job uses the workflow’s defined target Node version environment variable.

Changes:

  • Updated actions/setup-node configuration in the publish job to use ${{ env.TARGET_NODE_VERSION }} (consistent with other jobs and the workflow env block).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rhamzeh
rhamzeh added this pull request to the merge queue May 7, 2026
Merged via the queue into main with commit 8ed8704 May 7, 2026
26 of 28 checks passed
@rhamzeh
rhamzeh deleted the fix/publish-node-version branch May 7, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
+1 more reviewer
@emilic emilic emilic approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rhamzeh @codecov-commenter @emilic