chore: fix releaser config#377
Conversation
WalkthroughUpdated Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #377 +/- ##
=======================================
Coverage 85.79% 85.79%
=======================================
Files 26 26
Lines 1267 1267
Branches 225 225
=======================================
Hits 1087 1087
Misses 110 110
Partials 70 70 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Updates the repository’s release-please configuration to better align release PRs/commits with the project’s Conventional Commit and changelog conventions.
Changes:
- Adds a
package-namefield to the root package config. - Updates changelog section mapping to explicitly handle
releasecommit type (hidden).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
🧹 Nitpick comments (1)
release-please-config.json (1)
7-7: Remove emptypackage-namefieldThe
"package-name": ""field at line 7 is ignored by release-please forrelease-type: "node", since the package name is inferred frompackage.json. Remove it to keep the configuration clean.♻️ Proposed cleanup
- "package-name": "",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@release-please-config.json` at line 7, The release-please config contains an empty "package-name" field that is ignored for release-type: "node"; remove the "package-name": "" entry from release-please-config.json so the tool will infer the package from package.json and keep the config clean (look for the "package-name" key in release-please-config.json and delete that property).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@release-please-config.json`:
- Line 7: The release-please config contains an empty "package-name" field that
is ignored for release-type: "node"; remove the "package-name": "" entry from
release-please-config.json so the tool will infer the package from package.json
and keep the config clean (look for the "package-name" key in
release-please-config.json and delete that property).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 8ae68181-6266-44e4-8a97-14b2c5150ab0
📒 Files selected for processing (1)
release-please-config.json
Description
What problem is being solved?
How is it being solved?
What changes are made to solve it?
References
Review Checklist
mainSummary by CodeRabbit