fix(deps): pin axios to 1.14.0 and fix brace-expansion audit vulnerability#363
Conversation
|
|
WalkthroughUpdated the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Pins axios to a known-safe version to prevent accidental installation of the compromised [email protected] via the previous caret range, improving supply-chain safety for this SDK.
Changes:
- Change
axiosdependency spec from^1.13.5to the exact version1.14.0.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
4eacf8e to
c4bef64
Compare
|
Addressed the review comment from @copilot-pull-request-reviewer — |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #363 +/- ##
=======================================
Coverage 85.80% 85.80%
=======================================
Files 26 26
Lines 1268 1268
Branches 249 249
=======================================
Hits 1088 1088
Misses 110 110
Partials 70 70 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
[email protected] was published via a supply chain attack and pulls in [email protected], a malicious package that deploys a RAT. The caret range ^1.13.5 would resolve to 1.14.1 on fresh installs. Pinning to 1.14.0 (the last known-safe release) until a verified clean version is available upstream. Also fixes a pre-existing moderate vulnerability in brace-expansion (GHSA-f886-m6hf-6m8v) surfaced by npm audit. Ref: https://socket.dev/blog/axios-npm-package-compromised
c4bef64 to
5d7ea15
Compare
What
axiosfrom^1.13.5to1.14.0(exact version)package-lock.jsonto resolve[email protected]and patch a pre-existingbrace-expansionvulnerabilityWhy
[email protected]was published via a supply chain attack, pulling in[email protected]— a malicious package that deploys a cross-platform RAT via apostinstallhook.1.14.1has since been unpublished from npm, but the previous^1.13.5range would have resolved to it while it was live.Pinning to
1.14.0(last known-safe release) makes the dependency explicit and immune to any future malicious patch-level publish in this range.The lockfile regeneration also surfaces and fixes a pre-existing moderate vulnerability in
brace-expansion(GHSA-f886-m6hf-6m8v) — bumped across all instances (1.1.12→1.1.13,2.0.2→2.0.3,5.0.4→5.0.5).Reference: https://socket.dev/blog/axios-npm-package-compromised
Follow-up
Once the Axios maintainers publish a verified clean release post-
1.14.0, the pin can be relaxed back to a range.