Skip to content

chore: npm audit fix#341

Merged
SoulPancake merged 5 commits into
mainfrom
chore/audit-fix
Feb 25, 2026
Merged

chore: npm audit fix#341
SoulPancake merged 5 commits into
mainfrom
chore/audit-fix

Conversation

@SoulPancake

@SoulPancake SoulPancake commented Feb 24, 2026

Copy link
Copy Markdown
Member

Description

What problem is being solved?

How is it being solved?

What changes are made to solve it?

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

Summary by CodeRabbit

  • Chores
    • Updated development tool versions to enhance code quality and testing capabilities.

Copilot AI review requested due to automatic review settings February 24, 2026 17:30
@SoulPancake
SoulPancake requested a review from a team as a code owner February 24, 2026 17:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai

coderabbitai Bot commented Feb 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

Updates three devDependencies in package.json: eslint from ^8.57.1 to ^10.0.2, jest from ^29.7.0 to ^19.0.2, and ts-jest from ^29.4.1 to ^27.0.3. No changes to other fields, scripts, or configuration.

Changes

Cohort / File(s) Summary
DevDependencies Version Updates
package.json
Bumped eslint to ^10.0.2, jest to ^19.0.2, and ts-jest to ^27.0.3.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • rhamzeh
  • ewanharris
  • sergiught
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: npm audit fix' is clear and directly related to the changeset, which updates devDependencies versions in package.json as a maintenance task.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/audit-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dosubot

dosubot Bot commented Feb 24, 2026

Copy link
Copy Markdown

Related Documentation

Checked 8 published document(s) in 1 knowledge base(s). No updates required.

How did I do? Any feedback?  Join Discord

@codecov-commenter

codecov-commenter commented Feb 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.00%. Comparing base (7e95579) to head (02a3c4c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #341   +/-   ##
=======================================
  Coverage   90.00%   90.00%           
=======================================
  Files          25       25           
  Lines        1531     1531           
  Branches      266      289   +23     
=======================================
  Hits         1378     1378           
  Misses         95       95           
  Partials       58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@socket-security

socket-security Bot commented Feb 24, 2026

Copy link
Copy Markdown

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@SoulPancake
SoulPancake marked this pull request as draft February 24, 2026 17:41

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@package.json`:
- Around line 34-36: The package version conflict is between "eslint" and the
two TypeScript ESLint packages; update package.json so the peer ranges align:
either downgrade "eslint" from "10.0.2" to a compatible ^9.x release, or upgrade
both "@typescript-eslint/eslint-plugin" and "@typescript-eslint/parser" to a
release that explicitly supports ESLint 10 (e.g., the `@typescript-eslint` major
that lists eslint ^10 in its peerDependencies); modify the version strings for
"eslint" and/or the two "@typescript-eslint/*" entries accordingly, run your
package manager (npm/yarn/pnpm install) and re-run the linter to confirm the
conflict is resolved.
- Around line 36-39: The package.json currently lists incompatible dependency
combinations: update the testing stack by aligning jest and ts-jest (either
upgrade "jest" to a 27.x release to match "ts-jest" 27.0.3 and also set
"@types/jest" to a matching 27.x, or instead downgrade "ts-jest" to a version
that supports jest 19); and fix ESLint peer issues by aligning ESLint and
`@typescript-eslint` (either downgrade "eslint" to a 9.x release compatible with
"@typescript-eslint/eslint-plugin" 8.x or upgrade
"@typescript-eslint/eslint-plugin" to a version that supports "eslint" 10);
adjust the package.json entries for "jest", "ts-jest", "eslint",
"@typescript-eslint/eslint-plugin", and "@types/jest" accordingly and run
npm/yarn install and tests to verify no remaining peer conflicts.

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7e95579 and 6ac79d8.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • package.json

Comment thread package.json Outdated
Comment thread package.json Outdated
Comment thread package.json Outdated
@SoulPancake
SoulPancake marked this pull request as ready for review February 24, 2026 18:28
Comment thread package.json Outdated
@SoulPancake SoulPancake mentioned this pull request Feb 25, 2026
4 tasks
@SoulPancake

Copy link
Copy Markdown
Member Author

thanks
I guess we can do the eslint bump and these separately
Currently hitting just the audit fix for #342 if that's alright

@SoulPancake
SoulPancake requested a review from rhamzeh February 25, 2026 12:13
@SoulPancake
SoulPancake added this pull request to the merge queue Feb 25, 2026
Merged via the queue into main with commit 92ef2d2 Feb 25, 2026
27 checks passed
@SoulPancake
SoulPancake deleted the chore/audit-fix branch February 25, 2026 13:05
@coderabbitai coderabbitai Bot mentioned this pull request May 7, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants