🤖 Fix all nitpicks with AI agents

Verify each finding against the current code and only fix it if needed.


In `@errors.ts`:
- Around line 217-221: The constructor for the error class currently ignores the
optional context when err is an AxiosError; update the AxiosError branch in the
constructor to apply context overrides (clientId, audience, grantType) after
extracting values from the parsed request data so that if
context.clientId/audience/grantType is provided it replaces the parsed value;
locate the AxiosError handling block in the constructor and merge values (e.g.,
finalClientId = context?.clientId ?? parsedClientId) for each of the three
fields and use those merged values where the code currently uses the parsed
ones.

In `@tests/credentials.test.ts`:
- Around line 541-569: Add assertions to the existing test that checks thrown
error properties: after awaiting
expect(credentials.getAccessTokenHeader()).rejects.toThrow(FgaApiAuthenticationError)
also capture the rejected error and assert its context fields and status code
are set correctly (e.g., verify error.clientId equals OPENFGA_CLIENT_ID,
error.audience equals OPENFGA_API_AUDIENCE, error.grantType equals
CredentialsMethod.ClientCredentials or the literal grant type string used, and
error.statusCode equals 404). Use the same test-local variables (apiTokenIssuer,
OPENFGA_CLIENT_ID, OPENFGA_API_AUDIENCE) and the
Credentials.getAccessTokenHeader / FgaApiAuthenticationError symbols to locate
where to add these assertions.

errors.ts (1)

217-221: context parameter is silently ignored when err is an AxiosError.

The AxiosError branch (lines 264–272) extracts clientId, audience, and grantType only from parsed request data, ignoring the context argument. Today no caller passes context with an AxiosError, but a future caller could hit this silently. Consider applying context overrides in the AxiosError branch as well, or documenting that context is only used for FgaApiError inputs.

Proposed fix

-    this.clientId = data?.client_id;
-    this.audience = data?.audience;
-    this.grantType = data?.grant_type;
+    this.clientId = context?.clientId || data?.client_id;
+    this.audience = context?.audience || data?.audience;
+    this.grantType = context?.grantType || data?.grant_type;

Also applies to: 253-272

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@errors.ts` around lines 217 - 221, The constructor for the error class
currently ignores the optional context when err is an AxiosError; update the
AxiosError branch in the constructor to apply context overrides (clientId,
audience, grantType) after extracting values from the parsed request data so
that if context.clientId/audience/grantType is provided it replaces the parsed
value; locate the AxiosError handling block in the constructor and merge values
(e.g., finalClientId = context?.clientId ?? parsedClientId) for each of the
three fields and use those merged values where the code currently uses the
parsed ones.

tests/credentials.test.ts (1)

541-569: Good regression test — consider asserting error properties too.

The instanceof check directly validates the fix for #328. For stronger coverage, you could also verify that context fields (clientId, audience, grantType) and statusCode are correctly propagated on the thrown error.

Example: assert error properties

-      await expect(credentials.getAccessTokenHeader()).rejects.toThrow(FgaApiAuthenticationError);
+      await expect(credentials.getAccessTokenHeader()).rejects.toSatisfy((err: FgaApiAuthenticationError) => {
+        expect(err).toBeInstanceOf(FgaApiAuthenticationError);
+        expect(err.statusCode).toBe(404);
+        expect(err.clientId).toBe(OPENFGA_CLIENT_ID);
+        expect(err.audience).toBe(OPENFGA_API_AUDIENCE);
+        expect(err.grantType).toBe("client_credentials");
+        return true;
+      });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/credentials.test.ts` around lines 541 - 569, Add assertions to the
existing test that checks thrown error properties: after awaiting
expect(credentials.getAccessTokenHeader()).rejects.toThrow(FgaApiAuthenticationError)
also capture the rejected error and assert its context fields and status code
are set correctly (e.g., verify error.clientId equals OPENFGA_CLIENT_ID,
error.audience equals OPENFGA_API_AUDIENCE, error.grantType equals
CredentialsMethod.ClientCredentials or the literal grant type string used, and
error.statusCode equals 404). Use the same test-local variables (apiTokenIssuer,
OPENFGA_CLIENT_ID, OPENFGA_API_AUDIENCE) and the
Credentials.getAccessTokenHeader / FgaApiAuthenticationError symbols to locate
where to add these assertions.