Skip to content

fix: add cross-suite nock state corruption fix#312

Merged
SoulPancake merged 1 commit into
openfga:test/pr-285-nocksfrom
SoulPancake:test/pr-285-nocks
Feb 9, 2026
Merged

fix: add cross-suite nock state corruption fix#312
SoulPancake merged 1 commit into
openfga:test/pr-285-nocksfrom
SoulPancake:test/pr-285-nocks

Conversation

@SoulPancake

@SoulPancake SoulPancake commented Feb 9, 2026

Copy link
Copy Markdown
Member
  • Add tests/setup.ts with nock.cleanAll() and nock.restore() in afterAll
  • Add setupFilesAfterEnv in jest.config.js to wire up the setup file

Description

What problem is being solved?

How is it being solved?

What changes are made to solve it?

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@SoulPancake
Downgrade nock to ^14.0.10 and add cross-suite nock state corruption fix
8f52387 
- Downgrade nock from 15.0.0-beta.7 to ^14.0.10
- Add tests/setup.ts with nock.cleanAll() and nock.restore() in afterAll
- Add setupFilesAfterEnv in jest.config.js to wire up the setup file
- No callback API changes needed (nock 14 uses this.req pattern)

Co-authored-by: SoulPancake <[email protected]>
@SoulPancake
SoulPancake requested a review from a team as a code owner February 9, 2026 06:00
@coderabbitai

coderabbitai Bot commented Feb 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@SoulPancake
SoulPancake merged commit cbd30a1 into openfga:test/pr-285-nocks Feb 9, 2026
18 of 19 checks passed
@dosubot

dosubot Bot commented Feb 9, 2026

Copy link
Copy Markdown

Related Documentation

Checked 7 published document(s) in 1 knowledge base(s). No updates required.

How did I do? Any feedback?  Join Discord

@codecov-commenter

codecov-commenter commented Feb 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (test/pr-285-nocks@4c91cd3). Learn more about missing BASE report.

Additional details and impacted files 
@@                 Coverage Diff                  @@
##             test/pr-285-nocks     #312   +/-   ##
====================================================
  Coverage                     ?   88.61%           
====================================================
  Files                        ?       25           
  Lines                        ?     1493           
  Branches                     ?      279           
====================================================
  Hits                         ?     1323           
  Misses                       ?      148           
  Partials                     ?       22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SoulPancake SoulPancake mentioned this pull request May 11, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SoulPancake @codecov-commenter