Skip to content

chore: remove dependency on node url#300

Merged
rhamzeh merged 1 commit into
mainfrom
fix/remove-node-url-dependency
Feb 5, 2026
Merged

chore: remove dependency on node url#300
rhamzeh merged 1 commit into
mainfrom
fix/remove-node-url-dependency

Conversation

@rhamzeh

@rhamzeh rhamzeh commented Jan 13, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

URL is globaly available in both modern browsers and node - we do not need to import it from node specifically

Description

What problem is being solved?

How is it being solved?

What changes are made to solve it?

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

Summary by CodeRabbit

  • Chores
    • Internal code optimization to reduce module dependencies.

✏️ Tip: You can customize this high-level summary in your review settings.

@rhamzeh
chore: remove dependency on node url
1e6a997 
URL is globaly available in both modern browsers and node - we do not need to import it from node specifically
@rhamzeh
rhamzeh requested a review from a team as a code owner January 13, 2026 19:39
Copilot AI review requested due to automatic review settings January 13, 2026 19:39
@coderabbitai

coderabbitai Bot commented Jan 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Walkthrough

Removed the import of URL from the "url" module in telemetry/attributes.ts, relying instead on the global URL constructor. The usage of new URL() remains unchanged. No modifications to public interfaces or exported entities.

Changes

Cohort / File(s) Summary
Import Cleanup
telemetry/attributes.ts		 Removed unused import of URL from "url" module; code now uses the global URL constructor

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: remove dependency on node url' accurately and concisely describes the main change: removing an import of Node's url module from telemetry/attributes.ts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Docstrings were successfully generated.
📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 75aaf9f and 1e6a997.

📒 Files selected for processing (1)
  • telemetry/attributes.ts
💤 Files with no reviewable changes (1)
  • telemetry/attributes.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dosubot

dosubot Bot commented Jan 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Related Documentation

Checked 5 published document(s) in 1 knowledge base(s). No updates required.

How did I do? Any feedback?  Join Discord

@codecov-commenter

codecov-commenter commented Jan 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.44%. Comparing base (af1f9cc) to head (1e6a997).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #300      +/-   ##
==========================================
- Coverage   89.45%   89.44%   -0.01%     
==========================================
  Files          24       24              
  Lines        1299     1298       -1     
  Branches      234      234              
==========================================
- Hits         1162     1161       -1     
  Misses         81       81              
  Partials       56       56

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI reviewed Jan 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@coderabbitai

coderabbitai Bot commented Jan 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Caution

Docstrings generation - FAILED

No docstrings were generated.

SoulPancake
SoulPancake approved these changes Jan 14, 2026
View reviewed changes

@SoulPancake SoulPancake left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@rhamzeh
rhamzeh added this pull request to the merge queue Feb 5, 2026
Merged via the queue into main with commit 0c97b0b Feb 5, 2026
24 of 26 checks passed
@rhamzeh
rhamzeh deleted the fix/remove-node-url-dependency branch February 5, 2026 13:04
@rhamzeh rhamzeh mentioned this pull request Feb 9, 2026
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@SoulPancake SoulPancake SoulPancake approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rhamzeh @codecov-commenter @SoulPancake