common.ts (5)

145-147: Allow Retry-After: 0 and handle small negative skew

RFC allows Retry-After of 0 (immediate retry). Also clamp small negative delays due to clock skew to 0.

Apply this diff:

-function isValidRetryDelay(delayMs: number): boolean {
-  return delayMs > 0 && delayMs <= 1800 * 1000;
-}
+function isValidRetryDelay(delayMs: number): boolean {
+  return delayMs >= 0 && delayMs <= 1800 * 1000;
+}

-    const dateValue = new Date(retryAfterValue);
-    const now = new Date();
-    const delayMs = dateValue.getTime() - now.getTime();
+    const dateValue = new Date(retryAfterValue);
+    const now = new Date();
+    const delayMs = Math.max(0, dateValue.getTime() - now.getTime());
 
-    if (isValidRetryDelay(delayMs)) {
+    if (isValidRetryDelay(delayMs)) {
       return delayMs;
     }

Also applies to: 172-179

---

139-144: Avoid 0ms backoff when minWaitInMs is unset (burst risk)

With minWaitInMs=0, randomTime returns 0ms. Use a small floor to prevent tight loops.

Apply this diff:

-function randomTime(loopCount: number, minWaitInMs: number): number {
-  const min = Math.ceil(2 ** loopCount * minWaitInMs);
-  const max = Math.ceil(2 ** (loopCount + 1) * minWaitInMs);
+function randomTime(loopCount: number, minWaitInMs: number): number {
+  const base = Math.max(minWaitInMs, 50); // 50ms floor
+  const min = Math.ceil(2 ** loopCount * base);
+  const max = Math.ceil(2 ** (loopCount + 1) * base);
   const calculatedTime = Math.floor(Math.random() * (max - min) + min);
   return Math.min(calculatedTime, 120 * 1000);
 }

---

276-279: Default retry params can yield 0ms backoff

If configuration.retryParams is undefined and options omit retryParams, minWaitInMs becomes 0. Ensure sane defaults when maxRetry > 0.

Apply this diff:

-  const retryParams = axiosArgs.options?.retryParams ? axiosArgs.options?.retryParams : configuration.retryParams;
-  const maxRetry:number = retryParams ? retryParams.maxRetry : 0;
-  const minWaitInMs:number = retryParams ? retryParams.minWaitInMs : 0;
+  const retryParams = axiosArgs.options?.retryParams ?? configuration.retryParams;
+  const maxRetry: number = retryParams?.maxRetry ?? 0;
+  const minWaitInMs: number = maxRetry > 0 ? Math.max(50, retryParams?.minWaitInMs ?? 200) : 0;

---

230-266: Optional: include 408 (Request Timeout) in retryable statuses

408 is commonly safe to retry with backoff.

Apply this diff:

-      } else if (status === 429 || (status >= 500 && status !== 501)) {
+      } else if (status === 408 || status === 429 || (status >= 500 && status !== 501)) {

---

200-201: Optional: narrow return type (never returns undefined after fixes)

Control flow always returns a WrappedAxiosResponse or throws. Simplify the signature.

Apply this diff:

-): Promise<WrappedAxiosResponse<R> | undefined> {
+): Promise<WrappedAxiosResponse<R>> {

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

common.ts:1

• The test verifies that elapsed time is less than 2500ms but doesn't verify the lower bound (should be at least ~2000ms to confirm the Retry-After header was respected). Add an assertion like expect(elapsedTime).toBeGreaterThanOrEqual(1900).

/**

common.ts:1

• The test for 'valid Retry-After header (integer seconds)' verifies the result but doesn't verify that the delay was actually respected (lines 945-949). Add assertions to check that elapsed time is approximately 2 seconds, similar to the HTTP date test at line 987.

/**