chore(ci): test on node@22 and node@24#247
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughUpdated the GitHub Actions workflow to introduce a root-level NODE_VERSION env var, expand the Node.js version matrix to include 22.x and 24.x, and standardize setup-node steps to use the env-driven version across build, test, and publish jobs. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Suggested reviewers
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
=======================================
Coverage 89.55% 89.55%
=======================================
Files 25 25
Lines 1475 1475
Branches 254 277 +23
=======================================
Hits 1321 1321
Misses 93 93
Partials 61 61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/main.yaml(3 hunks)
🔇 Additional comments (2)
.github/workflows/main.yaml (2)
93-93: Publishing on 24.x: make the source of the version explicit after removing the global env.If you remove the root-level env, this reference will break. Either hardcode the desired publish version or set a job-level env for publish.
Apply one of the following:
Option A — hardcode 24.x here:
- node-version: ${{ env.NODE_VERSION }} + node-version: '24.x'Option B — set job-level env and keep this line:
# inside `publish:` job env: NODE_VERSION: '24.x'Note: Consider publishing with the active LTS (22.x) unless you require Node 24 features. Verify your release pipeline (npm, node-gyp, optional native deps) is compatible with Node 24 before switching.
21-21: CI Matrix & Engine Check for Node 16We’ve verified the
engines.nodefields in allpackage.jsonfiles:
- repo root (
package.json): ≥16.15.0example1/package.json: ≥16.13.0opentelemetry/package.json: ≥16.13.0No
.nvmrcfiles were found and no other workflows pin Node 16. Since your packages still support Node 16, it’s safe to keep16.xin the CI matrix. If you’d rather drop Node 16 to reduce EOL-related flakiness, please:
- Remove
16.xfrom the matrix in.github/workflows/main.yaml- Update all
engines.nodeentries in yourpackage.jsonfiles to>=18.x
d20f869 to
461c2b0
Compare
|
Audit failure is fixed by #248 |
461c2b0 to
975a023
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a Git URL format issue in package.json and updates the GitHub Actions workflows by adding Node.js versions 22.x and 24.x to the test matrix, centralizing the target Node version configuration, and refactoring dependency auditing into a separate job.
- Fixed incorrect Git URL format in package.json (colon to slash)
- Updated Node.js version matrix and centralized version configuration
- Separated npm audit into dedicated job and added fetch-depth to scorecard workflow
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Corrected Git URL format from git://github.com: to git://github.com/ |
| .github/workflows/scorecard.yml | Added fetch-depth: 0 to checkout action for complete repository history |
| .github/workflows/main.yaml | Added Node 22.x and 24.x to test matrix, introduced TARGET_NODE_VERSION env var, moved audit to separate job, and updated version references |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
410e21a to
ba832cf
Compare
|
Related Documentation Checked 7 published document(s) in 1 knowledge base(s). No updates required. How did I do? Any feedback? |
Description
Test on recent node versions, 22 (LTS) and 24 (current, upcoming LTS), change base build to node@24.
See: https://nodejs.org/en/about/previous-releases#release-schedule
What problem is being solved?
How is it being solved?
What changes are made to solve it?
References
Review Checklist
mainSummary by CodeRabbit