Use provided axios instance for credentials refresh operations#193
Merged
ewanharris merged 1 commit intoJan 8, 2025
Merged
Conversation
6 tasks
wassil
reviewed
Jan 8, 2025
wassil
left a comment
wassil
left a comment
There was a problem hiding this comment.
Thank you for doing this!
Looks good to me, I did it the same way when fixing this locally.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #193 +/- ##
=======================================
Coverage 87.65% 87.65%
=======================================
Files 23 23
Lines 1142 1142
Branches 198 179 -19
=======================================
Hits 1001 1001
Misses 83 83
Partials 58 58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that when users provide a custom axios instance to OpenFgaClient, it's consistently used throughout all SDK operations - including credential refresh requests. Previously, credential refresh operations were using the global axios instance, which caused issues for users with custom network configurations like VPC or proxy setups.
References
fixes #183
Review Checklist
main