Typo fix and Improve readability#164
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #164 +/- ##
=======================================
Coverage 87.94% 87.94%
=======================================
Files 23 23
Lines 1120 1120
Branches 171 171
=======================================
Hits 985 985
Misses 83 83
Partials 52 52 ☔ View full report in Codecov by Sentry. |
ewanharris
reviewed
Oct 7, 2024
ewanharris
left a comment
ewanharris
left a comment
Member
There was a problem hiding this comment.
Some comments about the changes here
Co-authored-by: Ewan Harris <[email protected]>
Co-authored-by: Ewan Harris <[email protected]>
Co-authored-by: Ewan Harris <[email protected]>
ewanharris
added this pull request to the merge queue
Oct 10, 2024
Contributor
Author
|
Hey @ewanharris can you add Thanks for letting me contribute |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Typo fix and Improve readability
References
This is for the openfga/sdk-generator#425
Review Checklist
main