fix: error correctly if apiUrl is not provided#161
Merged
Conversation
Modified the OpenFgaClient constructor to throw a FgaRequiredParamError with a clear message when the apiUrl parameter is not provided.
6 tasks
ewanharris
requested changes
Oct 4, 2024
Co-authored-by: Ewan Harris <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
==========================================
- Coverage 87.94% 87.93% -0.02%
==========================================
Files 23 23
Lines 1120 1119 -1
Branches 171 171
==========================================
- Hits 985 984 -1
Misses 83 83
Partials 52 52 ☔ View full report in Codecov by Sentry. |
ewanharris
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide a brief summary of the changes
Description
Provide a detailed description of the changes
This PR refactors the validation logic in the Configuration class to improve error handling for the apiUrl parameter. The changes ensure consistent validation across parameters (apiUrl, apiScheme, and apiHost) and improve readability and maintainability by using the assertParamExists utility function.
References
Review Checklist
main