feat: add batch check telemetry attribute#143
Merged
jimmyjames merged 6 commits intomainfrom Feb 18, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #143 +/- ##
============================================
+ Coverage 33.07% 33.12% +0.04%
- Complexity 984 985 +1
============================================
Files 182 182
Lines 6896 6902 +6
Branches 769 771 +2
============================================
+ Hits 2281 2286 +5
Misses 4509 4509
- Partials 106 107 +1 ☔ View full report in Codecov by Sentry. |
rhamzeh
previously approved these changes
Feb 6, 2025
Contributor
Author
|
Holding on this until we can verify default attribute handling (when no telemetry configured) is working properly. |
jimmyjames
force-pushed
the
feat/batch-check-otel
branch
from
baedf12 to
3e48702
Compare
Contributor
Author
Resolved with #145 |
rhamzeh
approved these changes
Feb 18, 2025
This was referenced Feb 18, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds telemetry attribute
fga-client.request.batch_check_sizeto capture number of checks in batch check requestReferences
Similar to openfga/js-sdk@59c000b
Review Checklist
main