Skip to content

fix: remove UI theme#30

Merged
rhamzeh merged 1 commit into
mainfrom
chore/theme-fix
Sep 6, 2024
Merged

fix: remove UI theme#30
rhamzeh merged 1 commit into
mainfrom
chore/theme-fix

Conversation

@d-jeffery

@d-jeffery d-jeffery commented Jun 21, 2024

Copy link
Copy Markdown
Contributor

Description

openfgaintellijplugin-0.1.2.zip

Theme in VSCode Dark Modern:

image

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@d-jeffery
d-jeffery requested a review from rhamzeh June 21, 2024 15:50
@d-jeffery
d-jeffery marked this pull request as ready for review June 21, 2024 16:40
@d-jeffery
d-jeffery requested review from a team as code owners June 21, 2024 16:40
rhamzeh
rhamzeh previously approved these changes Jun 26, 2024

@rhamzeh rhamzeh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d-jeffery looks good - but the token for the condition in the type restrictions seems weird - why is it coloured differently in all the themes?

Screenshot 2024-06-26 at 9 57 18 AM
Screenshot 2024-06-26 at 9 43 11 AM
Screenshot 2024-06-26 at 9 43 37 AM
Screenshot 2024-06-26 at 9 43 50 AM
Screenshot 2024-06-26 at 9 56 32 AM
Screenshot 2024-06-26 at 9 56 52 AM
Screenshot 2024-06-26 at 9 57 02 AM
Screenshot 2024-06-26 at 9 57 09 AM

@rhamzeh
rhamzeh dismissed their stale review June 26, 2024 14:00

Waiting for feedback

@rhamzeh
rhamzeh merged commit aa96ae1 into main Sep 6, 2024
@rhamzeh
rhamzeh deleted the chore/theme-fix branch September 6, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use the standard tokens for the tokenizer

3 participants