feat: add support for specifying consistency parameter#70
Merged
jimmyjames merged 5 commits intomainfrom Aug 23, 2024
Merged
Conversation
rhamzeh
changed the title
rhamzeh
changed the title
rhamzeh
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
==========================================
+ Coverage 30.96% 31.15% +0.19%
==========================================
Files 119 122 +3
Lines 6030 6083 +53
Branches 784 785 +1
==========================================
+ Hits 1867 1895 +28
- Misses 4007 4030 +23
- Partials 156 158 +2 ☔ View full report in Codecov by Sentry. |
This reverts commit e7bf34e.
jimmyjames
force-pushed
the
feat/consistency-parameter
branch
from
82a54c7 to
fe663b4
Compare
ewanharris
approved these changes
Aug 23, 2024
Member
ewanharris
left a comment
ewanharris
left a comment
There was a problem hiding this comment.
Looks good to me, I'd also suggest @rhamzeh takes a look as he's more familiar with the SDK/the issue with the unspecified enum
rhamzeh
commented
Aug 23, 2024
Member
Author
rhamzeh
left a comment
rhamzeh
left a comment
There was a problem hiding this comment.
I can't approve my own PR, but ✅ from me. Thanks @jimmyjames!
This was referenced Aug 23, 2024
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 28, 2024
## Release v0.5.0 - feat: support consistency parameter (#70)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for specifying the consistency parameter.
Description
Supports the ability to specify the consistency parameter for those endpoints that accept it (read, check, list users, list objects, and expand).
Note that a change to
JsonStringEnumMemberConverteris also required to support the new enumUNSPECIFIEDalong with itsEnumMembervalue (alsoUNSPECIFIED). Otherwise, there are errors when attempting to add the same key twice to the dictionary.In addition to the included unit tests, manual testing was also done using the example application to verify that the enum changes work as expected, and that the consistency parameter is being sent.
References
Review Checklist
main