Skip to content

feat: support nuget prereleases#109

Merged
rhamzeh merged 3 commits intomainfrom
feat-support-nuget-prerelease
Jun 5, 2025
Merged

feat: support nuget prereleases#109
rhamzeh merged 3 commits intomainfrom
feat-support-nuget-prerelease

Conversation

@ryanpq
Copy link
Contributor

@ryanpq ryanpq commented Jun 5, 2025

Description

Modifies GitHub Workflow to make the following changes:

  • prevents creating a release in GitHub for tags with a dash "-"
  • Pushing tags like "v1.1-alpha.1" or "v1.1-dev.1" will trigger creation and publication of a pre-release nuget package but will not create a release in GitHub
  • Pushing a tag like "v1.1-alpha.1" or "v1.1-dev.1" will trigger creation of a nuget package and testing of the process but will not publish the package to nuget

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@ryanpq ryanpq requested a review from a team as a code owner June 5, 2025 18:51
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.70%. Comparing base (2c79124) to head (f4c1d48).

❌ Your project status has failed because the head coverage (31.70%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #109   +/-   ##
=======================================
  Coverage   31.70%   31.70%           
=======================================
  Files         135      135           
  Lines        6848     6848           
  Branches      900      900           
=======================================
  Hits         2171     2171           
  Misses       4489     4489           
  Partials      188      188

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rhamzeh rhamzeh changed the title feat:Support nuget prereleases feat: support nuget prereleases Jun 5, 2025
@rhamzeh rhamzeh added this pull request to the merge queue Jun 5, 2025
Merged via the queue into main with commit f88bbec Jun 5, 2025
13 of 16 checks passed
@rhamzeh rhamzeh deleted the feat-support-nuget-prerelease branch June 5, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ryanpq @codecov-commenter @rhamzeh

Comments