Skip to content

feat(model/test): support running list users tests#315

Merged
ewanharris merged 1 commit into
mainfrom
feat/list-users-tests
May 2, 2024
Merged

feat(model/test): support running list users tests#315
ewanharris merged 1 commit into
mainfrom
feat/list-users-tests

Conversation

@ewanharris

@ewanharris ewanharris commented May 1, 2024

Copy link
Copy Markdown
Member

Description

Adds support for running list_users tests in the store file, remote and locally and updates the two examples stores to demonstrate the syntax.

An example of the error output is below

ⅹ ListUsers(object={Type:folder Id:product-2021},relation=can_view,user_filter={Type:user Relation:<nil>}): expected={Users:[user:anne user:bob] ExcludedUsers:[]}, got={Users:[user:anne user:beth] ExcludedUsers:[]}

This is based on #314 so draft until that PR is merged and then I'll rebase here.

References

Closes #304

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@ewanharris
ewanharris requested review from a team as code owners May 1, 2024 11:11
@ewanharris
ewanharris marked this pull request as draft May 1, 2024 11:11
@ewanharris
ewanharris force-pushed the feat/list-users-tests branch from 53196c4 to 9ef3fac Compare May 1, 2024 11:17
rhamzeh
rhamzeh previously approved these changes May 2, 2024
@github-merge-queue
github-merge-queue Bot dismissed rhamzeh’s stale review May 2, 2024 14:23

The merge-base changed after approval.

@ewanharris
ewanharris force-pushed the feat/list-users-tests branch from 9ef3fac to a26b091 Compare May 2, 2024 14:23
@ewanharris
ewanharris marked this pull request as ready for review May 2, 2024 14:25
@ewanharris
ewanharris requested a review from rhamzeh May 2, 2024 14:25
@ewanharris
ewanharris added this pull request to the merge queue May 2, 2024
Merged via the queue into main with commit 09898bd May 2, 2024
@ewanharris
ewanharris deleted the feat/list-users-tests branch May 2, 2024 15:11
@ewanharris ewanharris mentioned this pull request May 7, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support list_users in the Store File

2 participants