Skip to content

[WIP] Use multi-stage build for CSharp #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexellis merged 2 commits into from
Sep 8, 2017
Merged

[WIP] Use multi-stage build for CSharp #82

alexellis merged 2 commits into from
Sep 8, 2017

Conversation

@rorpage
Copy link
Contributor

@rorpage rorpage commented Sep 6, 2017 •
edited
Loading

Signed-off-by: Robbie Page [email protected]

Description

I have updated the csharp template to use multi-stage. The first stage is using the dotnet SDK, and the second uses the runtime.

Motivation and Context

The dotnet images are rather large so by implementing a multi-stage build, we decrease the end function image.

  • I have raised an issue to propose this change (required)
    #53

How Has This Been Tested?

I updated my template locally, created a new csharp function, built, deployed, and invoked the function and saw that everything ran as expected.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@rorpage rorpage mentioned this pull request Sep 6, 2017
Closed
@alexellis
Copy link
Member

alexellis commented Sep 6, 2017

Thanks for this. Can you try this with a new image name including pushing to the hub?

@alexellis
Copy link
Member

alexellis commented Sep 6, 2017

@rorpage did you say this is working now?

@alexellis
Copy link
Member

alexellis commented Sep 6, 2017 •
edited
Loading

I got:

exit status 145
Did you mean to run dotnet SDK commands? Please install dotnet SDK from: 
  http://go.microsoft.com/fwlink/?LinkID=798306&clcid=0x409

Right - I remember the issue. Please change the hard-coded fprocess in the Golang code with this PR. It'll fix everything.

Change it here:

https://github.com/alexellis/faas-cli/blob/a95a2809593fff93b07f44684ffc490ba4536c74/proxy/deploy.go#L31

@alexellis alexellis mentioned this pull request Sep 6, 2017
Closed
@alexellis alexellis changed the title update csharp template to use multi-stage [WIP] Use multi-stage build for CSharp Sep 7, 2017
@rorpage
Copy link
Contributor Author

rorpage commented Sep 8, 2017

@alexellis This has been tested locally with the deploy.go fix and am no longer getting the exit status message.

alexellis
alexellis approved these changes Sep 8, 2017
View reviewed changes
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work :-) this will make a difference for people

@alexellis alexellis merged commit 3a2e814 into openfaas:master Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexellis alexellis alexellis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rorpage @alexellis