This repository was archived by the owner on Nov 6, 2020. It is now read-only.
Clean up deprecated options and add CHECK macro #9036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorpaas
added
A0-pleasereview 🤓
Contributor
|
Thanks for that. I'll wait with #8963 for this. |
This was referenced Jul 4, 2018
andresilva
reviewed
Jul 9, 2018
Contributor
andresilva
left a comment
andresilva
left a comment
There was a problem hiding this comment.
LGTM. Minor question regarding arguments related to the dapps server.
parity/cli/mod.rs
Outdated
| FLAG flag_webapp: (bool) = false, or |_| None, | ||
| "-w, --webapp", | ||
| "Does nothing; dapps server is on by default now.", | ||
| "Does nothing; dapps server is removed.", |
Contributor
There was a problem hiding this comment.
Does nothing; dapps server has been removed.
parity/cli/mod.rs
Outdated
|
|
||
| ARG arg_dapps_port: (Option<u16>) = None, or |c: &Config| c.dapps.as_ref()?.port.clone(), | ||
| "--dapps-port=[PORT]", | ||
| "Dapps server is merged with HTTP JSON-RPC server. Use --jsonrpc-port.", |
Contributor
There was a problem hiding this comment.
Should these arguments say instead that the dapps server has been removed?
Collaborator
Author
There was a problem hiding this comment.
Yeah right. I checked, those arguments indeed does nothing.
5chdn
added
A8-looksgood 🦄
Contributor
|
|
dvdplm
added a commit
that referenced
this pull request
Jul 10, 2018
* master: Clean up deprecated options and add CHECK macro (#9036) Replace `std::env::home_dir` with `dirs::home_dir` (#9077) fix warning in secret-store test (#9074) SeedHashCompute remove needless `new` impl (#9063) remove trait bounds from several structs (#9055) docs: add changelog for 1.10.9 stable and 1.11.6 beta (#9069) Enable test in `miner/pool/test` (#9072)
5chdn
added a commit
that referenced
this pull request
Jul 10, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have added some deprecated options but forgot to include them in the
deprecatedmod. This makes users not be given any warnings if options are deprecated. This PR adds them back. In addition, options are organized by the version they were deprecated, this makes it possible to make a set of deprecation hard errors in the future.A CHECK macro is also added in
usage!. We had a hard coded check conditions in the macro before. Using the newCHECKsyntax we can move it out.Affects #9017. Deprecated
dappsoptions will need to be added to thedeprecatedmod.