Skip to content

Commit 64a63c1

Browse files
feanilclaude
andcommitted
build: hold pytest below 9.2.0 until pylint-pytest catches up
pytest 9.2.0 renamed the private FixtureManager._arg2fixturedefs to _arg2node2fixturedefs as part of the fixture-resolution rework in pytest-dev/pytest#14635. pylint-pytest 1.1.9.post1 still reads the old name in its pytest_sessionfinish hook, so with pytest 9.2.0 every file pylint checks fails with F0002 (astroid-error): AttributeError: 'FixtureManager' object has no attribute '_arg2fixturedefs'. Did you mean: '_arg2node2fixturedefs'? That is why all seven pylint jobs went red on the requirements bump that moved pytest 9.1.1 -> 9.2.0. The fix is upstream in pylint-dev/pylint-pytest#164 (approved, unreleased), tracked by pylint-dev/pylint-pytest#163. Constrain pytest to <9.2.0 in [tool.edx_lint].uv_constraints and regenerate with `make compile-requirements`; only pytest moves. Removing the constraint once a pylint-pytest release includes that fix is #39337. Co-Authored-By: Claude Fable 5.1 <[email protected]>
1 parent 3cbb05b commit 64a63c1

3 files changed

Lines changed: 15 additions & 4 deletions

File tree

‎pyproject.toml‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -292,6 +292,7 @@ constraint-dependencies = [
292292
"edx-enterprise==9.0.0",
293293
"djangorestframework<3.18",
294294
"openedx-forum<0.6.0",
295+
"pytest<9.2.0",
295296
]
296297
[tool.edx_lint]
297298
uv_constraints = [
@@ -414,6 +415,15 @@ uv_constraints = [
414415
# and fails `make pii_check`. It also isn't cleared on user retirement.
415416
# Issue for unpinning: https://github.com/openedx/forum/issues/301
416417
"openedx-forum<0.6.0",
418+
# Date: 2026-11-02
419+
# pytest 9.2.0 renamed the private FixtureManager._arg2fixturedefs that
420+
# pylint-pytest reads in its session-finish hook, so pylint crashes with
421+
# F0002 (astroid-error) on every file it checks. Fixed upstream in
422+
# https://github.com/pylint-dev/pylint-pytest/pull/164 but not yet released
423+
# (latest is 1.1.9.post1). Remove once a pylint-pytest release includes it.
424+
# Upstream bug: https://github.com/pylint-dev/pylint-pytest/issues/163
425+
# Issue for unpinning: https://github.com/openedx/openedx-platform/issues/39337
426+
"pytest<9.2.0",
417427
]
418428

419429
[tool.setuptools]

‎requirements/edx/development.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1156,7 +1156,7 @@ pysrt==1.1.2
11561156
# via
11571157
# edxval
11581158
# openedx-platform
1159-
pytest==9.2.0
1159+
pytest==9.1.1
11601160
# via
11611161
# pylint-pytest
11621162
# pytest-attrib

‎uv.lock‎

Lines changed: 4 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)