You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 200a08e
Browse filesBrowse the repository at this point in the historyBrowse files
Add actions/upload-code-coverage steps next to the existing Codecov
uploads in code-quality.yaml so coverage also lands in GitHub's native
Code Quality view on PRs. Python reuses the pytest-cov coverage.xml; Go
converts coverage-go.out to Cobertura via gocover-cobertura (GitHub's
documented recipe). Both are non-blocking (fail-on-error: false) and the
action self-skips fork PRs and merge_group runs. Adds code-quality:write
to the pytest-tests and go-tests jobs.
* ci: harden GitHub Code Quality coverage steps (review feedback)
- Guard both upload-code-coverage steps against a script injection in the
action's push path (it interpolates github.ref_name/github.ref into a
shell run:); skip the upload when the branch name contains $ ` " \ .
- Make the Go Cobertura conversion non-blocking (continue-on-error) and gate
the Go upload on its success, so optional coverage tooling can't fail the
go-tests job.
- Check out the PR head (head.sha) in both coverage jobs so reports map to the
commit the action attributes them to (matches the action's README example).
* ci: drop ref_name metachar guard; track upstream injection instead
The guard was security theater: the injection in actions/upload-code-coverage
is only reachable via push/workflow_dispatch to trusted branches, which already
require write access (= arbitrary CI execution). Replace the denylist with a
note linking the upstream report (actions/upload-code-coverage#26); the real
fix (inject via env:) belongs there.
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
* ci(code-quality): set persist-credentials:false on the go-tests checkout
Matches every other checkout in this workflow; the go-tests job now has
code-quality:write, so don't leave the token in .git/config for PR code to
reuse. The job only fetches public Go modules, so it needs no persisted creds.
---------
Co-authored-by: Claude Opus 4.8 (1M context) <[email protected]>
0 commit comments