Repository navigation
chore: Sync upstream feast-dev/feast master - #276
Merged
jyejare merged 5 commits intoNov 5, 2026
Merged
Conversation
* feat: Add Pinecone online store integration Signed-off-by: Siddhesh Khairnar <[email protected]> * fix: Align Pinecone store with filters API and operator types Signed-off-by: Siddhesh Khairnar <[email protected]> * test: Expand Pinecone online store unit test coverage Signed-off-by: Siddhesh Khairnar <[email protected]> * fix: Address Pinecone online store review feedback Signed-off-by: Siddhesh Khairnar <[email protected]> * ci: Retrigger CI after flaky macOS dependency download Signed-off-by: Siddhesh Khairnar <[email protected]> * fix: Resolve rebase conflicts keeping chronon and pinecone Signed-off-by: Siddhesh Khairnar <[email protected]> * fix: Prevent protobuf downgrade breaking grpc health checks Signed-off-by: Siddhesh Khairnar <[email protected]> * fix: Revert protobuf pin that broke flink and pixi lock Keep uv --no-sync for CI so hashed protobuf 7.x is preserved without conflicting with feast[flink]. Signed-off-by: Siddhesh Khairnar <[email protected]> --------- Signed-off-by: Siddhesh Khairnar <[email protected]>
Signed-off-by: Joystyxx <[email protected]> Co-authored-by: Shuchu Han <[email protected]>
…east-dev#7098) Several Args entries named a parameter the function does not have. Rename them to the actual parameter or drop them, and update the DecisionEvaluator example, which passed a DecisionStrategy that the constructor does not accept. Signed-off-by: mmporong <[email protected]> Co-authored-by: Shuchu Han <[email protected]>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
|
/early-gate-build |
patelchaitany
force-pushed
the
sync-upstream-2026-11-04
branch
from
November 4, 2026 09:39
645a997 to
23954da
Compare
|
/early-gate-build |
jyejare
approved these changes
Nov 4, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jyejare, patelchaitany The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Author
|
/retest |
|
All PipelineRuns for this commit have already succeeded. Use |
patelchaitany
force-pushed
the
sync-upstream-2026-11-04
branch
from
November 4, 2026 14:50
23954da to
6865ef4
Compare
|
New changes are detected. LGTM label has been removed. |
|
/early-gate-build |
patelchaitany
force-pushed
the
sync-upstream-2026-11-04
branch
from
November 4, 2026 15:18
6865ef4 to
1efd189
Compare
|
/early-gate-build |
…ev#7102) Bumps [minimatch](https://github.com/isaacs/minimatch) from 10.2.6 to 11.0.1. - [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md) - [Commits](isaacs/minimatch@v10.2.6...v11.0.1) --- updated-dependencies: - dependency-name: minimatch dependency-version: 11.0.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…6-11-04 Resolve conflicts: - .secrets.baseline: regenerate line numbers with detect-secrets for the merged tree, keeping generated_at unchanged. Signed-off-by: Chaitany Patel <[email protected]>
patelchaitany
force-pushed
the
sync-upstream-2026-11-04
branch
from
November 5, 2026 07:14
1efd189 to
4273c43
Compare
|
/early-gate-build |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #276 +/- ##
=========================================
Coverage ? 52.48%
=========================================
Files ? 472
Lines ? 59435
Branches ? 8720
=========================================
Hits ? 31192
Misses ? 26145
Partials ? 2098
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
The CI failures are not relevent, merging now. |
jyejare
pushed a commit
that referenced
this pull request
Nov 5, 2026
The upstream sync in #276 and the record-only fix in #281 were both squash-merged, so ODH master still has no link to upstream e0eb369. The scheduled sync job then merges the same upstream commits again and hits the same .secrets.baseline conflict. This merge uses the "ours" strategy, so no files change. It only records upstream e0eb369 as merged, so the next sync job starts from there. It must land as a merge commit; a squash drops the link. Signed-off-by: Chaitany Patel <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge upstream feast-dev/feast master (
e0eb36993, 4 commits) into downstream master. The automated sync job failed on one conflict:.secrets.baseline: both sides changed theline_numberforinfra/feast-operator/api/v1/featurestore_types.goand thegenerated_attime. Upstream's Pinecone change adds a line to that file, so I regenerated the line numbers withdetect-secretsfor the merged tree (1138for v1,681for v1alpha1) and keptgenerated_atat the downstream value.Upstream commits brought in:
Tested locally:
pre-commit run detect-secrets --all-filespasses, andgofmtis clean on the changed operator file. The operatorgo buildwas not run locally, so CI covers it.